[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPR: validate EBLIF parameters and fix them in verilog netlist writer #697

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

lpawelcz
Copy link
Contributor
@lpawelcz lpawelcz commented Jun 30, 2022

Motivate of the pull request

We would like to update VPR with some features and fixes that were introduced in upstream VPR with PR verilog-to-routing/vtr-verilog-to-routing#1663

Describe the technical details

What is currently done? (Provide issue link if applicable)

Current version of VPR writes faulty post-implementation netlist because of EBLIF parameters misinterpretation (binary parameters are interpreted as decimal).

What does this pull request change?

This PR improves in the following aspects:

  • Adds validation of EBLIF parameters - they are categorized as string, binary or decimal parameter
  • Fixes post-implementation verilog writer to add proper prefix before verilog parameter when it is needed

Which part of the code base require a change

  • VPR

Impact of the pull request

  • Fixed bug
  • Additional input validation

@github-actions github-actions bot added the VPR label Jun 30, 2022
… Verilog netlist

Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
@tangxifan tangxifan merged commit e220ddc into lnis-uofu:master Jun 30, 2022
@lpawelcz lpawelcz deleted the vpr-param-handling branch July 1, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants