[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix format_ptc_num() issues #699

Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix format_ptc_num() issues #699

merged 1 commit into from
Jun 30, 2022

Conversation

coolbreeze413
Copy link
Collaborator

Motivate of the pull request

Fix issues with the reworked format_ptc_num() function:

  • off by one error after split with delimiter
  • reusing same stringstream for multiple string to int conversions (clear before using again)

Describe the technical details

What is currently done? (Provide issue link if applicable)

reworked format_ptc_num() function has some issues.

What does this pull request change?

fix the logic in format_ptc_num()

Which part of the code base require a change

  • VPR read_route.cpp
  • Tileable routing architecture generator
  • OpenFPGA libraries
  • FPGA-Verilog
  • FPGA-Bitstream
  • FPGA-SDC
  • FPGA-SPICE
  • Flow scripts
  • Architecture library
  • Cell library
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

It does not look like it will impact existing cases, but requires review.

@tangxifan tangxifan merged commit c1d4783 into master Jun 30, 2022
@tangxifan tangxifan deleted the fix-format-ptc-num branch June 30, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants