check AWS Support validation status #11005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 35m 46s ⏱️ +10s Results for commit 2577871. ± Comparison against base commit de41959. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both. |
cloutierMat
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
You might say it the easy one, but it is a great resolution with great comments added to it!
I personally think that needs_fixing is fine for now. It could be useful though to be able to create a snapshot for them in the future. But that would make those tests harder to maintain...
sannya-singal
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the effort to validate tests, I've tried to run the AWS Support test against AWS.
It seems you need a Premium account to use the Support API. I had rewritten the test to be easily snapshot-able.
Changes
needs_fixingas you cannot run them against AWS without a premium plan. Debatable if this isneeds_fixingoronly_localstackthough, technically it's not by design, but also needs something specific.