[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: kinesis event payload #11078

Merged
merged 1 commit into from
Jun 25, 2024
Merged

parity: kinesis event payload #11078

merged 1 commit into from
Jun 25, 2024

Conversation

giograno
Copy link
Member
@giograno giograno commented Jun 24, 2024 •
edited
Loading

Motivation

This PR fixes a minor parity issue for AWS Lambda Kinesis Data Streams event source mappings.
As per docs, the event payload should have a kinesisSchemaVersion key.
Few libraries (e.g., AWS Java SDK) seem to expect this value.

Changes

  • adding kinesisSchemaVersion to the event payload;
  • removing snapshot skip from our tests;

@giograno giograno added aws:lambda AWS Lambda aws:kinesis Amazon Kinesis semver: patch Non-breaking changes which can be included in patch releases labels Jun 24, 2024
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±  0      2 suites  ±0   1h 12m 18s ⏱️ - 24m 2s
2 248 tests  - 903  1 963 ✅  - 792  285 💤  - 111  0 ❌ ±0 
2 252 runs   - 901  1 965 ✅  - 790  287 💤  - 111  0 ❌ ±0 

Results for commit b97f84a. ± Comparison against base commit e83d0a0.

This pull request removes 903 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@giograno giograno marked this pull request as ready for review June 24, 2024 22:52
joe4dev
joe4dev approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member
@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍
So easy 🙈

@giograno giograno merged commit ceb3983 into master Jun 25, 2024
39 checks passed
@giograno giograno deleted the parity-kinesis-lambda-int branch June 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

Assignees
No one assigned
Labels
aws:kinesis Amazon Kinesis aws:lambda AWS Lambda semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giograno @joe4dev