[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch test selection from opt-in to opt-out #11083

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

silv-io
Copy link
Member
@silv-io silv-io commented Jun 25, 2024

Motivation

After implementing the test selection, using it without any issues for a while, and with the merge of the acceptance tests only (#11049), we cat switch to an Opt-Out approach for the test selection (instead of the current opt-in).

Changes

Exchanges the current opt-in of the test selection to opt out.

@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Jun 25, 2024
Copy link
github-actions bot commented Jun 25, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 36m 47s ⏱️ + 1m 24s
3 151 tests ±0  2 755 ✅ ±0  396 💤 ±0  0 ❌ ±0 
3 153 runs  ±0  2 755 ✅ ±0  398 💤 ±0  0 ❌ ±0 

Results for commit 12e1a82. ± Comparison against base commit ceb3983.

♻️ This comment has been updated with latest results.

@silv-io silv-io marked this pull request as ready for review June 26, 2024 11:18
@silv-io silv-io removed the request for review from alexrashed June 26, 2024 11:18
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Makes sense to keep an explicit opt-out. Might be communicating the purpose clearer than simply adding a rule for each opt-out directly.

@silv-io
Copy link
Member Author
silv-io commented Jun 26, 2024

Great! I'll merge this once #11049 is done as that marks the final step of having the new setup up and running.

@silv-io
Copy link
Member Author
silv-io commented Jun 26, 2024

Since, doing the tests for #11049 will take some time due to resource limits, I'll merge this now already.

@silv-io silv-io merged commit 814bbf7 into master Jun 26, 2024
34 of 35 checks passed
@silv-io silv-io deleted the turn-testselection-opt-out branch June 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants