[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dead code related to S3 v1 (pre-ASF) #11093

Merged
merged 1 commit into from
Jun 27, 2024
Merged

remove dead code related to S3 v1 (pre-ASF) #11093

merged 1 commit into from
Jun 27, 2024

Conversation

bentsku
Copy link
Contributor
@bentsku bentsku commented Jun 26, 2024

Motivation

Looking at #11090, I saw some dead code related to the legacy S3 provider(true legacy, the legacy v1 and not v2 😄)

This PR removes it the dead code, and move a bit of code around related to APIGW as it is only used there.

Changes

  • remove dead code related to S3 select
  • move one function to APIGW helpers
  • remove a comment related to the dead code

@bentsku bentsku added the semver: patch Non-breaking changes which can be included in patch releases label Jun 26, 2024
@bentsku bentsku self-assigned this Jun 26, 2024
@bentsku bentsku changed the title remove dead code remove dead code related to S3 v1 (pre-ASF) Jun 26, 2024
@github-actions GitHub Actions
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   3m 39s ⏱️ +14s
404 tests ±0  352 ✅ ±0   52 💤 ±0  0 ❌ ±0 
808 runs  ±0  704 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit e1ccfdc. ± Comparison against base commit 301039f.

alexrashed
alexrashed approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧹

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 33m 51s ⏱️ - 1m 59s
3 151 tests ±0  2 755 ✅ ±0  396 💤 ±0  0 ❌ ±0 
3 153 runs  ±0  2 755 ✅ ±0  398 💤 ±0  0 ❌ ±0 

Results for commit e1ccfdc. ± Comparison against base commit 301039f.

cloutierMat
cloutierMat approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor
@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for taking the time to do some maintenance 🧹

@bentsku bentsku added aws:apigateway Amazon API Gateway and removed aws:apigateway Amazon API Gateway labels Jun 27, 2024
@bentsku bentsku merged commit 639c652 into master Jun 27, 2024
47 checks passed
@bentsku bentsku deleted the remove-legacy-code branch June 27, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@bentsku bentsku

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bentsku @alexrashed @cloutierMat