[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links in CONTRIBUTING.md and README.md #11102

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Fix broken links in CONTRIBUTING.md and README.md #11102

merged 7 commits into from
Jun 27, 2024

Conversation

l-melon
Copy link
Contributor
@l-melon l-melon commented Jun 27, 2024 •
edited
Loading

Motivation

PR for #11101

Changes

Fix broken link in CONTRIBUTING.md

  • integration testing
  • parity testing
  • Development Environment Setup
  • Contributor License Agreement

Testing

Open CONTRIBUTING.md and click these link.

localstack-bot
localstack-bot reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator
@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Collaborator
localstack-bot commented Jun 27, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@l-melon
Copy link
Contributor Author
l-melon commented Jun 27, 2024

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Jun 27, 2024
@localstack-bot
@l-melon has signed the CLA in #11102
3ad62f0
@l-melon
Copy link
Contributor Author
l-melon commented Jun 27, 2024

Hi, I'm new here. How do I add a label to a PR?

@l-melon l-melon changed the title Fix broken links in CONTRIBUTING.md Fix broken links in CONTRIBUTING.md and README.md Jun 27, 2024
@Badg
Copy link
Badg commented Jun 27, 2024

I noticed this the other day and was just about to do this but you beat me to it, nice!

@dominikschubert dominikschubert added semver: patch Non-breaking changes which can be included in patch releases area: documentation Issues related to LocalStack documentation labels Jun 27, 2024
@thrau thrau merged commit e06fcd0 into localstack:master Jun 27, 2024
19 checks passed
@thrau
Copy link
Member
thrau commented Jun 27, 2024

thank you for your contribution @l-melon ! 💯

@l-melon
Copy link
Contributor Author
l-melon commented Jun 28, 2024

Happy to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@HarshCasper HarshCasper HarshCasper approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees
No one assigned
Labels
area: documentation Issues related to LocalStack documentation semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@l-melon @localstack-bot @Badg @thrau @HarshCasper @dominikschubert