[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-2843) Add scope6 fact for every binding #2192

Merged
merged 1 commit into from
Nov 25, 2020
Merged

(FACT-2843) Add scope6 fact for every binding #2192

merged 1 commit into from
Nov 25, 2020

Conversation

oanatmaria
Copy link
Contributor

No description provided.

@oanatmaria oanatmaria added the enhancement New feature or enhancement label Nov 19, 2020
@oanatmaria oanatmaria requested review from a team November 19, 2020 07:25
@b4ldr
Copy link
Contributor
b4ldr commented Nov 19, 2020

would be nice to have a test for a global scope address e.g.

83: eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 state DOWN qlen 1000
    inet6 2001:d8b::1/64 scope global tentative 
       valid_lft forever preferred_lft forever

Otherwise LGTM me thanks

@oanatmaria
Copy link
Contributor Author

would be nice to have a test for a global scope address e.g.

83: eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 state DOWN qlen 1000
    inet6 2001:d8b::1/64 scope global tentative 
       valid_lft forever preferred_lft forever

Otherwise LGTM me thanks

There are tests to verify multiple scope address in this file and there is one with a global scope also

facter/spec/facter/resolvers/utils/networking/networking_spec.rb

Line 52 in 21c0f1a

context "when address's scope is global" do

@b4ldr
Copy link
Contributor
b4ldr commented Nov 24, 2020 •
edited
Loading

There are tests to verify multiple scope address in this file and there is one with a global scope also

facter/spec/facter/resolvers/utils/networking/networking_spec.rb

Line 52 in 21c0f1a

context "when address's scope is global" do

Great thanks

@BogdanIrimie BogdanIrimie merged commit 7245bc3 into puppetlabs:main Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BogdanIrimie BogdanIrimie BogdanIrimie approved these changes

Assignees
No one assigned
Labels
enhancement New feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oanatmaria @b4ldr @BogdanIrimie