MAINT: Add deprecate_with_replacement to StreamObject.initializeFromD… #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 51 51
Lines 8547 8549 +2
Branches 1703 1703
=======================================
+ Hits 8132 8134 +2
Misses 261 261
Partials 154 154 ☔ View full report in Codecov by Sentry. |
|
I'm wondering if the comment was not here to ignore coverage only |
|
@pubpub-zz But we already had the correctly named replacement, but no deprecation warning for it. Thus the comment does not really make sense here and rather looks like an oversight. Nevertheless, we should probably consider adding at least a no coverage pragma to the offending line. |
pubpub-zz
approved these changes
Jun 27, 2024
MartinThoma
added a commit
that referenced
this pull request
Jul 21, 2024
## What's new ### Bug Fixes (BUG) - Cope with Matrix entry in field annotations (#2736) ### Robustness (ROB) - Cope with fields with upside down box/rectangle (#2729) by @pubpub-zz ### Documentation (DOC) - Update Link Documentation Example (#2759) by @jparris - Make table consistent with pdf-version-support.md (#2758) by @j-t-1 - Add feature support by pypdf (#2738) by @j-t-1 - Move JavaScript example (#2746) by @j-t-1 - Added example for downloading a PDF from Google Cloud Storage (#2745) by @prodeveloper - Miscellaneous tiny changes (#2744) by @j-t-1 - Amend comment with rectangle duplication (#2733) by @j-t-1 - Use enumerate in extract example (#2727) by @j-t-1 - Tiny changes (#2723) by @j-t-1 ### Maintenance (MAINT) - Remove redundant pass statement (#2739) by @j-t-1 - Update Python version support documentation (#2740) by @j-t-1 - Remove redundant super() (#2734) by @j-t-1 - Add deprecate_with_replacement to StreamObject.initializeFromD… (#2728) by @j-t-1 ### Code Style (STY) - Change argument type (#2741) by @j-t-1 - Use endswith instead of logical equals (#2732) by @j-t-1 [Full Changelog](4.3.0...4.3.1)
Merged
stefan6419846
pushed a commit
that referenced
this pull request
Jul 21, 2024
## What's new ### Bug Fixes (BUG) - Cope with Matrix entry in field annotations (#2736) by @pubpub-zz ### Robustness (ROB) - Cope with fields with upside down box/rectangle (#2729) by @pubpub-zz ### Documentation (DOC) - Update Link Documentation Example (#2759) by @jparris - Make table consistent with pdf-version-support.md (#2758) by @j-t-1 - Add feature support by pypdf (#2738) by @j-t-1 - Move JavaScript example (#2746) by @j-t-1 - Added example for downloading a PDF from Google Cloud Storage (#2745) by @prodeveloper - Miscellaneous tiny changes (#2744) by @j-t-1 - Amend comment with rectangle duplication (#2733) by @j-t-1 - Use enumerate in extract example (#2727) by @j-t-1 - Tiny changes (#2723) by @j-t-1 ### Maintenance (MAINT) - Remove redundant pass statement (#2739) by @j-t-1 - Update Python version support documentation (#2740) by @j-t-1 - Remove redundant super() (#2734) by @j-t-1 - Add deprecate_with_replacement to StreamObject.initializeFromDictionary (#2728) by @j-t-1 - Deal with cryptography>=43 moving ARC4 (#2765) by @MartinThoma ### Code Style (STY) - Change argument type (#2741) by @j-t-1 - Use endswith instead of logical equals (#2732) by @j-t-1 [Full Changelog](4.3.0...4.3.1)
pubpub-zz
added a commit
to pubpub-zz/pypdf
that referenced
this pull request
Aug 11, 2024
add compress_identical_objects() discovered in py-pdf#2728 closes py-pdf#2794 closes py-pdf#2768
stefan6419846
pushed a commit
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ictionary