[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: CUDA softplus doesn't use opmath #77942

Closed
mruberry opened this issue May 20, 2022 · 0 comments
Closed

Bug: CUDA softplus doesn't use opmath #77942

mruberry opened this issue May 20, 2022 · 0 comments
Labels
module: nn Related to torch.nn module: primTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@mruberry
Copy link
Collaborator
mruberry commented May 20, 2022 •
edited by pytorch-bot bot
Loading

Discovered while adding a Python Reference for it. Looks like some other activation functions in Activation.cu also don't use opmath.

cc @albanD @mruberry @jbschlosser @walterddr @kshitij12345 @ezyang @ngimel
@mruberry mruberry added module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: primTorch labels May 20, 2022
@mruberry mruberry changed the title CUDA softplus doesn't use opmath Bug: CUDA softplus doesn't use opmath May 20, 2022
@mruberry mruberry mentioned this issue May 20, 2022
Closed
@khushi-411 khushi-411 mentioned this issue May 20, 2022
Closed
facebook-github-bot pushed a commit that referenced this issue May 24, 2022
@khushi-411 @facebook-github-bot
[fix] use opmath_t for activation functions in Activation.cu (#77949)…
7147ddb 
… (#77949)

Summary:
Fixes #77942

cc kshitij12345 mruberry ngimel

Pull Request resolved: #77949
Approved by: https://github.com/kshitij12345, https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8da4993557029d74d88a2641ae5c74d1abfc96bc

Reviewed By: seemethere

Differential Revision: D36603003

Pulled By: seemethere

fbshipit-source-id: 22ab7fb8ea83287cc842ff9bcdce1c6e756f6850
swang392 pushed a commit that referenced this issue May 25, 2022
@khushi-411 @swang392
[fix] use opmath_t for activation functions in Activation.cu (#77949)
c366c21 
Fixes #77942

cc @kshitij12345 @mruberry @ngimel
Pull Request resolved: #77949
Approved by: https://github.com/kshitij12345, https://github.com/ngimel
@wzzll123 wzzll123 mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: nn Related to torch.nn module: primTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] use opmath_t for activation functions in Activation.cu khushi-411/pytorch
1 participant
@mruberry