gh-120400 ：Support Linux perf profile to see Python calls on RISC-V architecture #120089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@pablogsal will be the proper reviewer. |
|
@ixgbe00 Thanks a lot for the contribution! This looks good to me but I would like to ensure this works as expected. Have you successfully run "test_perf_profiler" in a RISC-V system? |
yes, I have successfully run "test_perf_profiler" in a RISC-V system. Test environment: Test content refer to https://docs.python.org/3.12/howto/perf_profiling.html (python312_perf_venv) [root@openeuler-riscv64 pytorch]# cat my_script.py def bar(n): def baz(n): if name == "main": We can run perf to sample CPU stack traces at default hertz: Then we can use perf report to analyze the data: Total Lost Samples: 0 Samples: 1K of event 'cycles:P' Overhead Samples Command Shared Object Symbol |
|
I think there is some confusion here. The test I mention is the one in the test suite: ./python -m test test_perf_profiler -v |
I am terribly sorry. Thank you very much for your answer. |
|
Great!! Thanks a lot for checking @ixgbe00 👍 |
pablogsal
approved these changes
Jun 12, 2024
pablogsal
reviewed
Jun 12, 2024
Misc/NEWS.d/next/Core and Builtins/2024-06-05-06-26-04.gh-issue-
Outdated
Show resolved
Hide resolved
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
pablogsal
approved these changes
Jun 12, 2024
|
@ixgbe00 For us to merge the PR we need an issue number and to correct the NEWS entry. Do you mind opening a issue and changing the PR title per this instructions: https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting (We just need |
|
Also the NEWS entry file is called |
Thanks for your advice! I will open a issue and change the PR title. |
|
Congrats on your contribution @ixgbe00! 🚀 |
|
@Yhg1s This PR adds the trampoline to RISK-V + the configure detection. This is a new feature so technically we should not back port it, but I want us to consider adding it to 3.13 as this is quite isolated from anything else. WDYT? (Feel free to say "no") |
|
Yeah, it makes sense to backport this fix to the existing feature. |
|
Thanks @ixgbe00 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 12, 2024
…SC-V architecture (pythonGH-120089) (cherry picked from commit 4b1e85b) Co-authored-by: ixgbe00 <yangwang@iscas.ac.cn> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
GH-120413 is a backport of this pull request to the 3.13 branch. |
|
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…SC-V architecture (python#120089) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
This seems incomplete. It causes compilation to now fail on riscv64, due to missing support in perf_jit_trampoline.c: |
stefanor
added a commit
to stefanor/cpython
that referenced
this pull request
Jul 3, 2024
Until support is added in perf_jit_trampoline.c pythongh-120089 was incomplete.
stefanor
added a commit
to stefanor/cpython
that referenced
this pull request
Jul 3, 2024
Until support is added in perf_jit_trampoline.c pythongh-120089 was incomplete.
This has already been reported in #121201 |
pablogsal
pushed a commit
that referenced
this pull request
Jul 3, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2024
…-121328) Disable perf_trampoline on riscv64 for now Until support is added in perf_jit_trampoline.c pythongh-120089 was incomplete. (cherry picked from commit ca2e876) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
Thank you very much for your reminder. Can we add a test program for perf jit in test_perf_profiler? |
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…SC-V architecture (python#120089) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…21328) Disable perf_trampoline on riscv64 for now Until support is added in perf_jit_trampoline.c pythongh-120089 was incomplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request title
Refer to gh-96143:Allow Linux perf profiler to see Python calls
Refer to gh-96143:Move the perf trampoline files to the Python directory