[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121163: Add support for all as an valid alias for always in warnings.simplefilter and warnings.filterswarnings #121164

Merged
merged 3 commits into from
Jun 30, 2024
Merged

gh-121163: Add support for all as an valid alias for always in warnings.simplefilter and warnings.filterswarnings #121164

merged 3 commits into from
Jun 30, 2024
+49 −43

Conversation

Eclips4
Copy link
Member
@Eclips4 Eclips4 commented Jun 29, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 29, 2024
Closed
@Eclips4 Eclips4 requested a review from vstinner June 29, 2024 16:35
vstinner
vstinner approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It makes sense to support -Wall which is commonly used in GCC/clang. And making it as alias to "always" makes sense to "all" means showing "all" warnings. "default" or "once" would not fit -Wall.

kumaraditya303
kumaraditya303 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor
@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 1a84bdc into python:main Jun 30, 2024
36 checks passed
@vstinner
Copy link
Member

Merged, thanks.

@Eclips4 Eclips4 deleted the issue-121163 branch June 30, 2024 17:48
@Eclips4 Eclips4 mentioned this pull request Jun 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eclips4 @vstinner @kumaraditya303