-
-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120831: Increase the default minimum supported iOS version to 13.0 #121250
base: main
Are you sure you want to change the base?
Conversation
!buildbot iOS |
馃 New build scheduled with the buildbot fleet by @freakboy3742 for commit 20209cd 馃 The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot iOS |
馃 New build scheduled with the buildbot fleet by @freakboy3742 for commit 20209cd 馃 The command will test the builders whose names match following regular expression: The builders matched are:
|
The new buildbot configuration has been deployed; this build shows an auto detected iOS 13 minimum, and no build warnings (compared to the previous PR build, which shows 2 warnings associated with the SQLite issue). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with a tiny nit.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Bumps the default minimum iOS version from 12.0 to 13.0.
As discussed on #120831, the previous default value of 12.0 worked successfully at runtime, but raised a compilation warning about the usage of an SQLite API that wasn't added until iOS 13.0. Although protection exists in the code to prevent any runtime problem, avoiding the compilation warning was judged to be more important.
The usage of iOS 12 is estimated to be less that 0.5% of the total iOS install base, so the impact on the user base is minor. It's also only a default version; it's possible to manually configure any minimum version at compile time.
In addition to increasing the default minimum version, this PR modifies the logging generated by the configure script to be more explicit about the iOS deployment target (aka minimum version) that will be used. It also adds usage documentation about the default iOS supported version.
The buildbot will still generate the warning because it the iOS buildbot configuration currently hard-codes the 12.0 minimum supported version. I'll push an update for the buildbot configuration shortly.
Fixes #120831.
enclose 'sqlite3_create_window_function' in a __builtin_available check to silence this warning
聽#120831馃摎 Documentation preview 馃摎: https://cpython-previews--121250.org.readthedocs.build/