[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark multiple conversations as closed (WIP) #382

Closed

Conversation

ZmagoD
Copy link
Contributor
@ZmagoD ZmagoD commented Nov 9, 2020

Description

  • Added checkboxes to every conversation,
  • Store the conversation id in an array

Issue

#250

Screenshots

WIP

Screenshot 2020-11-09 at 22 17 11

Checklist

  • Everything passes when running mix test
  • Ran mix format
  • No frontend compilation warnings

@reichert621
Copy link
Collaborator

thanks for getting started on this @ZmagoD! I think we'll definitely need to think about how to make this look nicer from a UI/UX perspective... might be worth taking a look at some other similar products (like Intercom) to see how they handle this

@ZmagoD
Copy link
Contributor Author
ZmagoD commented Dec 1, 2020

HI @reichert621 when working on this I found a TODO comment and I'm a bit confused how to approach this task now
Screenshot 2020-12-01 at 21 36 59

Should we fire multiple queries or do a bulk update of selected items 🤔

My idea was to create an endpoint that will handle status changes for multiple conversations but I'm not sure if it is a good idea anymore 🤔

@reichert621
Copy link
Collaborator

hey @ZmagoD sorry i missed this!

i would need to think about this a little bit more (it's currently a low priority 😓) -- but i think ideally we would do a "bulk update" to close them (i think this is how you were thinking?)

in the "bulk closing" case, we'll probably want to change the notification that pops up though... we definitely don't want to show a little notification toast for every single conversation that was closed!

@ZmagoD
Copy link
Contributor Author
ZmagoD commented Feb 10, 2021

Hey @reichert621 I'm really sorry but I can't continue to work on this at the moment so I will close this PR if someone else wants to pick up this task.

@ZmagoD ZmagoD closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants