-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Tool: overwrites what I'm typing with unwanted SQL on slow connections #6357
Comments
We should disable the input till the script it loaded. |
RohitBhati8269
added a commit
to RohitBhati8269/pgadmin4
that referenced
this issue
May 31, 2024
RohitBhati8269
added a commit
to RohitBhati8269/pgadmin4
that referenced
this issue
Jun 4, 2024
RohitBhati8269
added a commit
to RohitBhati8269/pgadmin4
that referenced
this issue
Jun 4, 2024
RohitBhati8269
added a commit
to RohitBhati8269/pgadmin4
that referenced
this issue
Jun 4, 2024
RohitBhati8269
added a commit
to RohitBhati8269/pgadmin4
that referenced
this issue
Jun 6, 2024
adityatoshniwal
pushed a commit
that referenced
this issue
Jun 6, 2024
…vent users from typing. #6357
Issue fixed. Verified on snapshot build. Env: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
"Query Tool" has the following misfeature (using default settings): soon after opening, but not immediately after opening, the "Query" edit area is overwritten with the generic SQL for dropping/(re)creating whatever is currently focused in "Object Explorer".
Scripts
>CREATE Script
.If I opened "Query Tool", it is because I want to run my own SQL, not some random unsolicited default, thank you very much!
UPDATE: it looks like this behavior might be controlled by the (poorly named?) "Copy SQL from main window to query tool?" option (FWIW, I've never seen a "Main window" with any SQL in it, so I saw no reason to disable the option until I started experimenting some more for this bug report);
To Reproduce
Steps to reproduce the behavior:
N.B. this step is timing-sensitive and may be best reproduced using a non-local (slow-ish) PG connection;
Expected behavior
If something has already been typed by the time the query that computes the CREATE script comes back, then what has already been typed should be left alone (and the CREATE script thrown away in the trash where it belongs).
(and/or)
Rename "Copy SQL from main window to query tool?" or its uselessly redundant description ("Specifies whether or not to copy SQL to query tool from main window.") to something that corresponds to what's actually going on, so people who want to disable the behavior realize that this is perhaps the option that controls it.
Error message
n/a
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
A few years back pgAdmin III used to be a really good and usable tool. Now, some areas (esp. around "Query Tool") are borderline unusable, with useful features that used to be there (such as being able to freely edit the SELECT query generated after picking "View First ZZZ Rows") gone. Sigh.
The text was updated successfully, but these errors were encountered: