Remove inline styles #12262

nijel · 2016-05-17T08:04:30Z

Inline stying doesn't play well with themes and also forces us to use permisive Content-Security-Policy.

The styling should be moved completely to themes and after this is done the CSP should remove 'unsafe-inline' for styles.

The text was updated successfully, but these errors were encountered:

flash1452 · 2016-05-17T17:55:32Z

@nijel Does fixing this error include even those inline style statements that are used in some of the .js files??
And also I wanted to ask if I am allowed to use any id or class-name for those tags that have yet not been given any class or id names.

nijel · 2016-05-17T18:04:14Z

Yes to both answers. The definite goal is to remove inline usage from Conent-Security-Policy.

nijel · 2016-05-18T12:13:20Z

Also this doesn't have to be done all in one step, incremental patches are welcome!

…of issue phpmyadmin#12262) Signed-off-by: Andy Davies <contact@andy-davies.me>

Remove inline styles from elements with id='filterText' (partial fix …

…data'(partial fix of issue phpmyadmin#12262) Signed-off-by: Cristiano Lancelotti <lancelot.info@gmail.com>

…yadmin#12262

emanuelb · 2017-05-17T05:45:15Z

here list of style attribute usage: (use class or css via id instead)

./gis_data_editor.php:echo '<div id="placeholder" style="width:450px;height:300px;'
./gis_data_editor.php:echo '<div id="openlayersmap" style="width:450px;height:300px;'
./gis_data_editor.php:echo '<div class="choice" style="float:right;clear:right;">';
./index.php:        echo '<p style="margin: 0.5em 1em 0.5em 1em">';
./prefs_manage.php:            <div class="click-hide-message group-cnt" style="display:none">
./prefs_manage.php:                <div style="padding-bottom:0.5em">
./templates/error/report_form.twig:    <fieldset style="padding-top:0">
./templates/columns_definitions/column_name.phtml:    <p style="font-size:80%;margin:5px 2px"
./templates/database/designer/having_query_panel.twig:<table id="query_having" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/aggregate_query_panel.twig:<table id="query_Aggregate" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/side_menu.phtml:    <div id="name-panel" style="overflow:hidden">
./templates/database/designer/side_menu.phtml:        <span id="page_name" style="border:none">
./templates/database/designer/side_menu.phtml:        <span id="saved_state" style="border:none">
./templates/database/designer/database_tables.phtml:           style="position:absolute; left:<?= (isset($tab_pos[$t_n])
./templates/database/designer/database_tables.phtml:                               style="margin: 0;"
./templates/database/designer/database_tables.phtml:        <tbody id="id_tbody_<?= $t_n_url; ?>" style="<?= (isset($tab_pos[$t_n]) && empty($tab_pos[$t_n]["V"])) ? 'display: none' : ''; ?>">
./templates/database/designer/database_tables.phtml:                                   style="margin: 0;"
./templates/database/designer/new_relation_panel.twig:<table id="layer_new_relation" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/delete_relation_panel.twig:<table id="layer_upd_relation" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/table_list.phtml:<div id="layer_menu" style="display:none;">
./templates/database/designer/table_list.phtml:        <table width="100%" style="padding-left: 3px;">
./templates/database/designer/table_list.phtml:                               style="margin:0;"
./templates/database/designer/rename_to_panel.twig:<table id="query_rename_to" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/query_details.phtml:    <div style="clear:both;">
./templates/database/designer/query_details.phtml:    <div style="clear:both;">
./templates/database/designer/options_panel.twig:<table id="pmd_optionse" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/designer/where_query_panel.twig:<table id="query_where" style="display:none;" width="5%" cellpadding="0" cellspacing="0">
./templates/database/structure/check_all_tables.phtml:    <select name="submit_mult" style="margin: 0 3em 0 3em;">
./templates/div_for_slider_effect.twig:        style="display: none; overflow:auto;"{% endif %} class="pma_auto_slider"
./templates/privileges/require_options.phtml:                <div id="specified_div" style="padding-left:20px;">
./templates/server/databases/table_row.phtml:        <td class="tool" style="text-align: center;">
./templates/server/databases/table_row.phtml:        <td class="tool" style="text-align: center;">
./templates/server/variables/link_template.phtml:<a style="display: none;" href="<?= $url; ?>" class="ajax saveLink">
./templates/server/variables/link_template.phtml:<a style="display: none;" href="#" class="cancelLink">
./templates/table/gis_visualization/gis_visualization.phtml:        <div id="gis_div" style="position:relative;">
./templates/table/gis_visualization/gis_visualization.phtml:            <div class="pma_quick_warp" style="width: 50px; position: absolute; right: 0; top: 0; cursor: pointer;">
./templates/table/gis_visualization/gis_visualization.phtml:                    <span class="drop_button" style="padding: 0; border: 0;">
./templates/table/gis_visualization/gis_visualization.phtml:        <div style="clear:both;">&nbsp;</div>
./templates/table/gis_visualization/gis_visualization.phtml:             style="width:<?= htmlspecialchars($visualizationSettings['width']); ?>
./templates/table/structure/move_columns_dialog.phtml:<div id="move_columns_dialog" title="<?= __('Move columns'); ?>" style="display: none">
./templates/table/structure/optional_action_links.phtml:            ); ?>" style="margin-right: 0;">
./templates/table/chart/tbl_chart.phtml:                <span class="span_pie" style="display:none;">
./templates/table/chart/tbl_chart.phtml:                <span class="span_timeline" style="display:none;">
./templates/table/chart/tbl_chart.phtml:                <span class="span_scatter" style="display:none;">
./templates/table/chart/tbl_chart.phtml:                <span class="barStacked" style="display:none;">
./templates/table/chart/tbl_chart.phtml:                <input style="margin-top:0;" type="text" name="xaxis_label"
./templates/table/chart/tbl_chart.phtml:            <p style="clear:both;">&nbsp;</p>
./templates/table/chart/tbl_chart.phtml:            <p style="clear:both;">&nbsp;</p>
./templates/table/chart/tbl_chart.phtml:            <div id="resizer" style="width:600px; height:400px;">
./templates/table/chart/tbl_chart.phtml:                <div style="position: absolute; right: 10px; top: 10px; cursor: pointer; z-index: 1000;">
./templates/table/search/options.phtml:<br style="clear: both;" />
./templates/table/search/zoom_result_form.phtml:                    <div id="querydata" style="display:none">
./templates/table/search/zoom_result_form.phtml:        <div id="dataDisplay" style="display:none">
./templates/prefs_autoload.twig:<div id="prefs_autoload" class="notice print_ignore" style="display:none">
./templates/select_all.twig:<i style="margin-left: 2em">{% trans 'With selected:' %}</i>
./themes/svg_gradient.php:    <rect width="100%" height="100%" style="fill:url(#linear-gradient);" />
./libraries/Util.php:                . ' style="text-align: ' . $GLOBALS['cell_align_left'] . '"'
./libraries/Util.php:                     . ' method="post"' . $target . ' style="display: inline;">';
./libraries/Util.php:                $selected = 'selected="selected" style="font-weight: bold"';
./libraries/Util.php:            . '<div id="upload_form_status" style="display: none;"></div>'
./libraries/Util.php:            . '<div id="upload_form_status_info" style="display: none;"></div>'
./libraries/Util.php:                . '    <select style="margin: 5px" size="1" '
./libraries/config/FormDisplay.tpl.php:            . '" style="display:none">' . $icons['edit'] . '</a>';
./libraries/config/FormDisplay.tpl.php:            .  __('Restore default value') . '" style="display:none">'
./libraries/sql.lib.php:        $profiling_table .= '<div id="profilingChartData" style="display:none;">';
./libraries/sql.lib.php:        $profiling_table .= '<div id="profilingchart" style="display:none;">';
./libraries/sql.lib.php:            . 's<span style="display:none;" class="rawvalue">'
./libraries/sql.lib.php:            . 's<span style="display:none;" class="rawvalue">'
./libraries/sql.lib.php:            . 's<span style="display:none;" class="rawvalue">'
./libraries/DbQbe.php:        $html_output .= '<select style="width: ' . $this->_realwidth
./libraries/DbQbe.php:                    . ' style="width: ' . $this->_realwidth . '"'
./libraries/DbQbe.php:                . ' style="width: ' . $this->_realwidth . '"'
./libraries/DbQbe.php:                    . ' style="width: ' . $this->_realwidth . '" size="20" />';
./libraries/DbQbe.php:                . ' style="width: ' . $this->_realwidth . '" size="20" />';
./libraries/DbQbe.php:        $html_output .= '<table class="data" style="width: 100%;">';
./libraries/DbQbe.php:        $html_output .= '<div class="floatleft" style="width:50%">';
./libraries/navigation/Navigation.php:                        $html .= '<td style="width:80px"><a href="navigation.php'
./libraries/server_status_variables.lib.php:        $retval .= '<span style="display:none;" class="original">';
./libraries/server_status_advisor.lib.php:    $output .= '<div id="advisorInstructionsDialog" style="display:none;">';
./libraries/server_status_advisor.lib.php:    $output .= '<div id="advisorData" style="display:none;">';
./libraries/tracking.lib.php:        <th style="width: 300px"><?php echo __('Table');?></th>
./libraries/central_columns.lib.php:    $table_navigation_html = '<table style="display:inline-block;max-width:49%" '
./libraries/central_columns.lib.php:        . '<th class="" style="display:none"></th>'
./libraries/central_columns.lib.php:        . ' style="min-width: 100%;">';
./libraries/central_columns.lib.php:    $columnAdd = '<table style="display:inline-block;margin-left:1%;max-width:50%" '
./libraries/central_columns.lib.php:        . '<td style="padding:1.5% 0em">'
./libraries/central_columns.lib.php:        . '<td id="save_' . $row_num . '" style="display:none">'
./libraries/rte/rte_export.lib.php:            $export_data = '<textarea cols="40" rows="15" style="width: 100%;">'
./libraries/index.lib.php:    $html_output .= '<fieldset class="tblFooters print_ignore" style="text-align: '
./libraries/replication_gui.lib.php:        $html .= ' <div id="slave_control_gui" style="display: none">';
./libraries/replication_gui.lib.php:    $html .= ' <div id="slave_errormanagement_gui" style="display: none">';
./libraries/replication_gui.lib.php:    $html .= '<div id="replication_' . $type . '_section" style="';
./libraries/replication_gui.lib.php:    $html .= '  <div id="replication_slaves_section" style="';
./libraries/DatabaseInterface.php:                = '<span style="color:red">'
./libraries/display_export.lib.php:    $html .= '<div class="floatleft" style="margin-left: 50px;">';
./libraries/insert_edit.lib.php:        return '<span style="border-bottom: 1px dashed black;" title="'
./libraries/insert_edit.lib.php:        return '<span style="color:red">' . __('Error') . '</span><br />' . "\n"
./libraries/plugins/auth/AuthenticationConfig.php:    <table cellpadding="0" cellspacing="3" style="margin: 0 auto" width="80%">
./libraries/plugins/schema/dia/TableStatsDia.php:                <dia:font family="monospace" style="0" name="Courier"/>
./libraries/plugins/schema/dia/TableStatsDia.php:                <dia:font family="sans" style="80" name="Helvetica-Bold"/>
./libraries/plugins/schema/dia/TableStatsDia.php:                <dia:font family="sans" style="0" name="Helvetica"/>
./libraries/plugins/schema/dia/RelationStatsDia.php:                <dia:font family="monospace" style="0" name="Courier"/>
./libraries/server_status_monitor.lib.php:    $retval .= __('Log statistics') . '" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= __('Query analyzer') . '" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= __('Monitor Instructions') . '" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<div class="monitorUse" style="display:none;">';
./libraries/server_status_monitor.lib.php:        . __('Add chart') . '" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<span class="divisorInput" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<span class="unitInput" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<span id="clearSeriesLink" style="display:none;">';
./libraries/server_status_monitor.lib.php:    $retval .= '<a href="#endChartEditMode" style="display:none;">';
./libraries/display_import.lib.php:        . 'width="1" height="1" style="display: none;"></iframe>';
./libraries/display_import.lib.php:    $html .= '<div id="import_form_status" style="display: none;"></div>';
./libraries/display_import.lib.php:        . 'width="16" height="16" alt="ajax clock" style="display: none;" />';
./libraries/server_user_groups.lib.php:        $html_output .= '<th style="white-space: nowrap">'
./libraries/ErrorHandler.php:                $retval .= ' style="display:none;"';
./libraries/export.lib.php:    $html = '<div style="text-align: ' . $GLOBALS['cell_align_left'] . '">';
./libraries/server_privileges.lib.php:        . ' name="user_exists_warning" style="display:none;">'
./libraries/server_privileges.lib.php:                $html_output .= '<span style="color: #FF0000">'
./libraries/server_privileges.lib.php:                    ? '<span style="color: #FF0000">' . __('Any') . '</span>'
./libraries/server_privileges.lib.php:            $new_user_string .= '<span style="color: #FF0000">'
./libraries/server_privileges.lib.php:        . '<div class="clear_both" style="clear:both"></div>';
./libraries/server_privileges.lib.php:                    ? '<span style="color: #FF0000">' . __('Any') . '</span>'
./libraries/server_privileges.lib.php:                $html_output .= '<span style="color: #FF0000">' . __('No')
./libraries/relation.lib.php:    $messages['error'] = '<span style="color:red"><strong>'
./libraries/relation.lib.php:    $messages['ok'] = '<span style="color:green"><strong>'
./libraries/relation.lib.php:    $messages['enabled']  = '<span style="color:green">' . __('Enabled') . '</span>';
./libraries/relation.lib.php:    $messages['disabled'] = '<span style="color:red">'   . __('Disabled') . '</span>';
./libraries/DisplayResults.php:            . '<i style="margin-left: 2em">' . __('With selected:') . '</i>' . "\n";
./setup/frames/config.inc.php:echo '<td class="lastrow" style="text-align: left">';
./setup/frames/index.inc.php:echo '<a href="#" id="show_hidden_messages" style="display:none">';
./setup/frames/index.inc.php:    echo '<table cellspacing="0" class="datatable" style="table-layout: fixed">';
./setup/frames/index.inc.php:        echo '<td style="white-space: nowrap">';
./setup/frames/index.inc.php:echo '<td class="lastrow" style="text-align: left">';
./setup/frames/index.inc.php:echo '<td colspan="2" class="lastrow" style="text-align: left">';
./js/messages.php:    . '" class="floatright" style="margin-top: 20px;">'
./js/messages.php:    . '" class="floatright" style="margin-top: 20px;">'
./js/server_status_monitor.js:                ' style="width:' + chartSize.width + 'px; height:' + chartSize.height + 'px;"></div>' +
./js/server_status_monitor.js:            var tooltipHtml = '<div style="font-size:12px;background-color:#FFFFFF;' +
./js/server_status_monitor.js:            tooltipHtml += '<span style="font-weight:bold;">';
./js/server_status_monitor.js:                tooltipHtml += '<br /><span style="color:' + seriesColor + '">' +
./js/server_status_monitor.js:            var selectionBox = $('<div id="selection_box" style="z-index:1000;height:205px;position:absolute;background-color:#87CEEB;opacity:0.4;
./js/server_status_monitor.js:                        '        <input name="filterQueryText" type="text" id="filterQueryText" style="vertical-align: baseline;" />' +
./js/error_report.js:            '<div style="position:fixed;bottom:0;left:0;right:0;margin:0;' +
./js/functions.js:            fields += '<tr><td><div><span style="font-weight:bold">' +
./js/functions.js:                '</span><br><span style="color:gray">' + central_column_list[db + '_' + table][i].col_type;
./js/functions.js:                fields += '<td><input class="pick" style="width:100%" type="submit" value="' +
./js/functions.js:                        fields += '<tr><td><div><span style="font-weight:bold">' +
./js/functions.js:                            '</span><br><span style="color:gray">' +
./js/functions.js:                            fields += '<td><input class="pick" style="width:100%" type="submit" value="' +
./js/pmd/history.js:            str += '<td style="padding-left: 5px;" class="right">' + PMA_getImage('b_sbrowse.png', 'column name') + '</td>' +
./js/pmd/history.js:                '<td width="175" style="padding-left: 5px">' + history_array[i].get_column_name() + '<td>';
./js/rte.js:                data.message = '<textarea cols="40" rows="15" style="width: 100%;">' + data.message + '</textarea>';

here list of <style> tag usage: (use link to load css file instead)

./libraries/Header.php:                $retval .= '<style>html{display:block}</style>';
./libraries/Header.php:            $retval .= '<style id="cfs-style">html{display: none;}</style>';
./libraries/error.inc.php:    <style type="text/css">

codehimanshu · 2017-08-03T21:27:59Z

@nijel Please let me know if the inline styles are still existing. I would like to work on it.

MauricioFauth · 2017-08-03T21:47:48Z

@codehimanshu Thanks for the interest. There are still inline styles in some places.
Feel free to choose what you want to remove and send us a pull request.

codehimanshu · 2017-08-03T22:06:39Z

@MauricioFauth I am a newbee, so I need a bit guidence.
I want to remove inline style from /js/error_report.js
var $div = $( '<div style="position:fixed;bottom:0;left:0;right:0;margin:0;' + 'z-index:1000" class="error" id="error_notification"></div>'
Should I add a class here and add this particular css in /themes/original/css/common.css.php and /themes/pmahomme/css/common.css.php?

Signed-off-by: codehimanshu <himanshuagrawal1998@gmail.com>

partial fix issue #12262

Nilucshan · 2017-08-28T17:21:18Z

I would like to work on removing inline and i am also a newbie. I am not clear about what we are supposed to do when we remove those inline codes. Can anyone assist with this? Any help is highly appreciated.

codehimanshu · 2017-08-28T18:31:11Z

@Nilucshan You can remove the inline css codes and add a class or ID to the element. Then apply the same CSS in the css files in themes/pmahomme/css/common.css.php Also check the layout on browser if poosible. Refer to any of the above PRs for help.

stephangrobler · 2018-10-18T08:31:58Z

I see that the travis CI failed on the docs section of the build, is this an issue with the code I submitted?

Refer:phpmyadmin#12262 Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>

#12262 Closes: #14980 Signed-off-by: William Desportes <williamdes@wdes.fr>

…e _common.scss files; Partial fix of issue: phpmyadmin#12262 Signed-off-by: Ron Holt <holt.ronald@gmail.com>

Pull-request: #15538 Ref: #12262 Signed-off-by: William Desportes <williamdes@wdes.fr>

emanuelb · 2020-08-27T18:21:43Z

Results for:

Searching <style to catch <style> tag without src=:

templates/error/generic.twig:8:    <style type="text/css">
templates/header.twig:10:    <style id="cfs-style">html{display: none;}</style>
templates/header.twig:28:  <noscript><style>html{display:block}</style></noscript>

Searching style= to catch style attribute usage:

js/designer/move.js:559:        '            style="margin:0;"' +
js/designer/history.js:104:            str += '<td style="padding-left: 5px;" class="right">' + Functions.getImage('b_sbrowse', Messages.strColumnName) + '</td>' +
js/designer/history.js:105:                '<td width="175" style="padding-left: 5px">' + $('<div/>').text(historyArray[i].getColumnName()).html() + '<td>';
libraries/classes/Plugins/Export/ExportMediawiki.php:211:                $output .= '{| class="wikitable" style="text-align:center;"'
libraries/classes/Plugins/Export/ExportMediawiki.php:221:                    $output .= '|- style="background:#ffdead;"' . $this->exportCRLF();
libraries/classes/Plugins/Export/ExportMediawiki.php:222:                    $output .= '! style="background:#ffffff" | '
libraries/classes/Plugins/Export/ExportMediawiki.php:301:        $output .= '{| class="wikitable sortable" style="text-align:center;"'
libraries/classes/Plugins/Schema/Dia/RelationStatsDia.php:229:                <dia:font family="monospace" style="0" name="Courier"/>
libraries/classes/Plugins/Schema/Dia/TableStatsDia.php:175:                <dia:font family="monospace" style="0" name="Courier"/>
libraries/classes/Plugins/Schema/Dia/TableStatsDia.php:178:                <dia:font family="sans" style="80" name="Helvetica-Bold"/>
libraries/classes/Plugins/Schema/Dia/TableStatsDia.php:181:                <dia:font family="sans" style="0" name="Helvetica"/>
libraries/classes/Html/Generator.php:1159:     *                           params (f.e. style="")
libraries/classes/Navigation/NavigationTree.php:1241:                $hide = " style='display: none;'";
libraries/classes/Database/Qbe.php:728:                    . ' style="width: ' . $this->realwidth . '"'
libraries/classes/Database/Qbe.php:762:                . ' style="width: ' . $this->realwidth . '"'
libraries/classes/Database/Qbe.php:881:                    . ' style="width: ' . $this->realwidth . '" size="20">';
libraries/classes/Database/Qbe.php:901:                . ' style="width: ' . $this->realwidth . '" size="20">';
libraries/classes/Database/Routines.php:1957:            $exportData = '<textarea cols="40" rows="15" style="width: 100%;">'
libraries/classes/Database/Events.php:609:            $exportData = '<textarea cols="40" rows="15" style="width: 100%;">'
libraries/classes/Database/Triggers.php:626:            $exportData = '<textarea cols="40" rows="15" style="width: 100%;">'
libraries/classes/InsertEdit.php:422:            return '<span style="border-bottom: 1px dashed black;" title="'
libraries/classes/InsertEdit.php:1583:            return '<span style="color:red">' . __('Error') . '</span><br>' . "\n"
libraries/classes/Util.php:1302:                $selected = 'selected="selected" style="font-weight: bold"';
js/vendor/jquery/jquery-ui-timepicker-addon.js:408:						html += '<div style="padding-left: 1px"><table class="ui-tpicker-grid-label"><tr>';
js/server/status/monitor.js:1218:                ' style="width:' + chartSize.width + 'px; height:' + chartSize.height + 'px;"></div>' +
js/server/status/monitor.js:1259:                tooltipHtml += '<br><span style="color:' + seriesColor + '">' +
js/server/status/monitor.js:2123:                explain += '<div class="explain-' + i + '"' + (i > 0 ?  'style="display:none;"' : '') + '>';
js/server/status/sorter.js:66:            var res = html.innerHTML.match(/<span(\s*style="display:none;"\s*)?\s*class="original">(.*)?<\/span>/);
templates/display/results/table.twig:107:      {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Options' %}"
templates/gis_data_editor_form.twig:18:        <div id="openlayersmap" style="width: {{width}}px; height: {{height}}px;"{{ srid == 0 ? ' class="hide"' }}></div>
templates/error/report_form.twig:3:    <fieldset style="padding-top:0">
templates/export.twig:25:    <div class="floatleft" style="margin-left: 50px;">
templates/table/structure/display_structure.twig:345:              " style="margin-right: 0;">
templates/table/structure/display_structure.twig:534:            {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Partitions' %}"
templates/table/gis_visualization/gis_visualization.twig:4:        <div id="gis_div" style="position:relative;">
templates/table/gis_visualization/gis_visualization.twig:45:            <div class="pma_quick_warp" style="width: 50px; position: absolute; right: 0; top: 0; cursor: pointer;">
templates/table/gis_visualization/gis_visualization.twig:47:                    <span class="drop_button" style="padding: 0; border: 0;">
templates/table/gis_visualization/gis_visualization.twig:68:             style="width:{{ visualization_settings['width'] }}px;height:{{ visualization_settings['height'] }}px;">
templates/table/index_form.twig:52:                {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Advanced options' %}"
templates/table/relation/common_form.twig:104:                {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Internal relationships' %}"
templates/table/search/index.twig:99:      {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Options' %}"
templates/table/chart/tbl_chart.twig:102:                <input style="margin-top:0;" type="text" name="xaxis_label" id="xaxis_label" value="{{ xaxis == -1 ? 'X Values'|trans : keys[xaxis] }}">
templates/table/chart/tbl_chart.twig:148:            <div id="resizer" style="width:600px; height:400px;">
templates/table/chart/tbl_chart.twig:149:                <div style="position: absolute; right: 10px; top: 10px; cursor: pointer; z-index: 1000;">
templates/database/multi_table_query/form.twig:53:                <div id="criteria_div{{ id }}" class="pma_auto_slider" title="{% trans 'criteria' %}" style="display: none; overflow:auto;">
templates/database/designer/database_tables.twig:18:        style="position:absolute; left:
templates/database/designer/database_tables.twig:28:                            style="margin: 0;"
templates/database/designer/database_tables.twig:64:            {{- tab_pos[t_n] is defined and tab_pos[t_n]['V'] is empty ? ' style="display: none"' }}>
templates/database/designer/database_tables.twig:90:                                style="margin: 0;"
templates/database/designer/main.twig:221:                <table width="100%" style="padding-left: 3px;"></table>
templates/database/structure/check_all_tables.twig:8:    <select name="submit_mult" style="margin: 0 3em 0 3em;">
templates/database/qbe/sort_select_cell.twig:2:    <select style="width:{{ real_width }}" name="criteriaSort[{{ column_number }}]" size="1">
templates/database/central_columns/main.twig:148:    <table style="display:inline-block;max-width:49%" class="navigation nospacing nopadding">
templates/server/replication/master_replication.twig:19:        <div id="replication_slaves_section" style="display: none;">
templates/server/replication/status_table.twig:1:<div id="replication_{{ type }}_section"{{ is_hidden ? ' style="display: none;"' }}>
templates/server/user_groups/user_groups.twig:8:                    <th style="white-space: nowrap">
templates/server/status/processes/list.twig:12:                  {%- trans 'Descending' %}" src="themes/dot.gif" style="display: {{ column.sort_order == 'DESC' ? 'none' : 'inline' }}">
templates/server/status/processes/list.twig:14:                  {%- trans 'Ascending' %}" src="themes/dot.gif" style="display: {{ column.sort_order == 'DESC' ? 'inline' : 'none' }}">
templates/server/privileges/privileges_table.twig:792:        <div id="specified_div" style="padding-left:20px;">

Search for style' and style" to catch usage inside JS/Templates:

templates/navigation/main.twig:60:          'style': 'visibility: hidden; display:none',

Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>

williamdes · 2022-10-13T19:05:42Z

To be done:

The following changes are not to be changed

Searching <style to catch <style> tag without src=:

templates/error/generic.twig:8:    <style type="text/css">
templates/header.twig:10:    <style id="cfs-style">html{display: none;}</style>
templates/header.twig:28:  <noscript><style>html{display:block}</style></noscript>

Pull-request: #17788 Ref: #12262 Signed-off-by: William Desportes <williamdes@wdes.fr>

nijel added enhancement A feature request for improving phpMyAdmin newbie labels May 17, 2016

andavies pushed a commit to andavies/phpmyadmin that referenced this issue May 26, 2016

Remove inline styles from elements with id='filterText' (partial fix …

a3ec4e4

…of issue phpmyadmin#12262) Signed-off-by: Andy Davies <contact@andy-davies.me>

andavies pushed a commit to andavies/phpmyadmin that referenced this issue May 26, 2016

Remove inline styles from elements with id='filterText' (partial fix …

786786d

…of issue phpmyadmin#12262) Signed-off-by: Andy Davies <contact@andy-davies.me>

andavies mentioned this issue May 26, 2016

Remove inline styles from elements with id='filterText' (partial fix … #12275

Merged

3 tasks

nijel referenced this issue May 27, 2016

Merge pull request #12275 from andavies/issue-#12262

8678125

Remove inline styles from elements with id='filterText' (partial fix …

ibennetch mentioned this issue Jul 1, 2016

Use dynamic strict CSP policy #12357

Open

clancelotti added a commit to clancelotti/phpmyadmin that referenced this issue Dec 17, 2016

Remove inline styles from elements with id='serverstatusquerieschart_…

7a5e234

…data'(partial fix of issue phpmyadmin#12262) Signed-off-by: Cristiano Lancelotti <lancelot.info@gmail.com>

clancelotti mentioned this issue Dec 17, 2016

Remove inline styles from elements with id='serverstatusquerieschart_… #12823

Merged

4 tasks

clancelotti added a commit to clancelotti/phpmyadmin that referenced this issue Dec 20, 2016

Remove inline styles from elements with id='serverstatusquerieschart_…

d3899dd

…data'(partial fix of issue phpmyadmin#12262) Signed-off-by: Cristiano Lancelotti <lancelot.info@gmail.com>

nijel mentioned this issue Feb 2, 2017

db_central_columns: new column collapsing issue #12939

Closed

4 tasks

emanuelb mentioned this issue Mar 16, 2017

Adding Security label for related issues #13089

Closed

nijel added the hardening label Mar 16, 2017

Juvenv pushed a commit to Juvenv/phpmyadmin that referenced this issue Apr 16, 2017

Remove inline styles from file templates/columns_atributes.phtml phpm…

2c37d6a

…yadmin#12262

MauricioFauth mentioned this issue May 23, 2017

Remove some inline CSS #13293

Merged

4 tasks

nijel mentioned this issue Jul 24, 2017

Interface design for Multi-table query #13342

Merged

4 tasks

codehimanshu added a commit to codehimanshu/phpmyadmin that referenced this issue Aug 4, 2017

partial fix issue phpmyadmin#12262

75d9386

Signed-off-by: codehimanshu <himanshuagrawal1998@gmail.com>

codehimanshu added a commit to codehimanshu/phpmyadmin that referenced this issue Aug 4, 2017

remove trailing whitespaces phpmyadmin#12262

104ab1e

Signed-off-by: codehimanshu <himanshuagrawal1998@gmail.com>

MauricioFauth added a commit that referenced this issue Aug 5, 2017

Merge pull request #13559 from codehimanshu/master

c3742fd

partial fix issue #12262

MauricioFauth added the help wanted label Sep 5, 2017

MauricioFauth mentioned this issue Sep 12, 2017

Added refresh button in export #13674

Merged

4 tasks

williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 25, 2018

rlratcliffe mentioned this issue Oct 30, 2018

Removing inline styles from php files and adding class to css #14696

Closed

6 tasks

stephangrobler mentioned this issue Nov 1, 2018

style: remove inline styles from function.js #14701

Merged

6 tasks

CXZ7720 mentioned this issue Nov 8, 2018

remove inline styles from server_status_monitor.js #14714

Closed

6 tasks

Bournvita1998 added a commit to Bournvita1998/phpmyadmin that referenced this issue Feb 26, 2019

Removed inline styles from js/server_status_monitor

3d43286

Refer:phpmyadmin#12262 Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>

Bournvita1998 mentioned this issue Feb 26, 2019

Removed inline styles from js/server_status_monitor #14980

Merged

6 tasks

williamdes added a commit that referenced this issue Mar 16, 2019

Removed inline styles from js/server_status_monitor

5e6fdf2

#12262 Closes: #14980 Signed-off-by: William Desportes <williamdes@wdes.fr>

williamdes removed the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Mar 16, 2019

williamdes mentioned this issue May 27, 2019

auto_increment field is too small #15287

Closed

GitarMan added a commit to GitarMan/phpmyadmin that referenced this issue Oct 18, 2019

Removed Inline Styles from form.twig; Added styles to respective them…

311fd7e

…e _common.scss files; Partial fix of issue: phpmyadmin#12262 Signed-off-by: Ron Holt <holt.ronald@gmail.com>

GitarMan mentioned this issue Oct 18, 2019

Removed Inline Styles from form.twig; Added styles to respective… #15510

Merged

GitarMan added a commit to GitarMan/phpmyadmin that referenced this issue Oct 18, 2019

Removed Inline Styles from form.twig; Added styles to respective them…

33147d1

…e _common.scss files; Partial fix of issue: phpmyadmin#12262 Signed-off-by: Ron Holt <holt.ronald@gmail.com>

GitarMan added a commit to GitarMan/phpmyadmin that referenced this issue Oct 18, 2019

Removed Inline Styles from form.twig; Added styles to respective them…

2d336a1

…e _common.scss files; Partial fix of issue: phpmyadmin#12262 Signed-off-by: Ron Holt <holt.ronald@gmail.com>

t-howell mentioned this issue Oct 30, 2019

fixed html element typo in indexes.js #15538

Merged

williamdes added this to Triage zone in Enhancements Jan 23, 2020

williamdes moved this from Triage zone to Code base in Enhancements Jan 23, 2020

williamdes added a commit that referenced this issue Jan 27, 2020

Merge #15538 - Ref #12262 Remove some inline CSS styles

5dcb477

Pull-request: #15538 Ref: #12262 Signed-off-by: William Desportes <williamdes@wdes.fr>

emanuelb mentioned this issue Jun 1, 2020

Add integration for errors/CSP violation reports (eg. using sentry) #16154

Open

Arpit-Gulgulia mentioned this issue Oct 13, 2022

Ref #12262 - Remove inline styles #17788

Merged

6 tasks

Arpit-Gulgulia added a commit to Arpit-Gulgulia/phpmyadmin-arpit that referenced this issue Oct 13, 2022

Fix:phpmyadmin#12262 Signed-off-by: Arpit Jain <arpitgulgulia@gmail.com>

ac81bb2

Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>

williamdes added a commit that referenced this issue Oct 14, 2022

Merge #17788 - Ref #12262 - Remove inline styles

c92621d

Pull-request: #17788 Ref: #12262 Signed-off-by: William Desportes <williamdes@wdes.fr>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove inline styles #12262

Remove inline styles #12262

Remove inline styles #12262

Remove inline styles #12262

Comments