-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inline styles #12262
Comments
@nijel Does fixing this error include even those inline style statements that are used in some of the .js files?? |
Yes to both answers. The definite goal is to remove inline usage from Conent-Security-Policy. |
Also this doesn't have to be done all in one step, incremental patches are welcome! |
…of issue phpmyadmin#12262) Signed-off-by: Andy Davies <contact@andy-davies.me>
…of issue phpmyadmin#12262) Signed-off-by: Andy Davies <contact@andy-davies.me>
Remove inline styles from elements with id='filterText' (partial fix …
…data'(partial fix of issue phpmyadmin#12262) Signed-off-by: Cristiano Lancelotti <lancelot.info@gmail.com>
…data'(partial fix of issue phpmyadmin#12262) Signed-off-by: Cristiano Lancelotti <lancelot.info@gmail.com>
here list of style attribute usage: (use class or css via id instead)
here list of <style> tag usage: (use link to load css file instead)
|
@nijel Please let me know if the inline styles are still existing. I would like to work on it. |
@codehimanshu Thanks for the interest. There are still inline styles in some places. |
@MauricioFauth I am a newbee, so I need a bit guidence. |
Signed-off-by: codehimanshu <himanshuagrawal1998@gmail.com>
Signed-off-by: codehimanshu <himanshuagrawal1998@gmail.com>
I would like to work on removing inline and i am also a newbie. I am not clear about what we are supposed to do when we remove those inline codes. Can anyone assist with this? Any help is highly appreciated. |
@Nilucshan You can remove the inline css codes and add a class or ID to the element. Then apply the same CSS in the css files in themes/pmahomme/css/common.css.php Also check the layout on browser if poosible. Refer to any of the above PRs for help. |
I see that the travis CI failed on the docs section of the build, is this an issue with the code I submitted? |
Refer:phpmyadmin#12262 Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>
…e _common.scss files; Partial fix of issue: phpmyadmin#12262 Signed-off-by: Ron Holt <holt.ronald@gmail.com>
…e _common.scss files; Partial fix of issue: phpmyadmin#12262 Signed-off-by: Ron Holt <holt.ronald@gmail.com>
…e _common.scss files; Partial fix of issue: phpmyadmin#12262 Signed-off-by: Ron Holt <holt.ronald@gmail.com>
Results for: Searching templates/error/generic.twig:8: <style type="text/css">
templates/header.twig:10: <style id="cfs-style">html{display: none;}</style>
templates/header.twig:28: <noscript><style>html{display:block}</style></noscript> Searching js/designer/move.js:559: ' style="margin:0;"' +
js/designer/history.js:104: str += '<td style="padding-left: 5px;" class="right">' + Functions.getImage('b_sbrowse', Messages.strColumnName) + '</td>' +
js/designer/history.js:105: '<td width="175" style="padding-left: 5px">' + $('<div/>').text(historyArray[i].getColumnName()).html() + '<td>';
libraries/classes/Plugins/Export/ExportMediawiki.php:211: $output .= '{| class="wikitable" style="text-align:center;"'
libraries/classes/Plugins/Export/ExportMediawiki.php:221: $output .= '|- style="background:#ffdead;"' . $this->exportCRLF();
libraries/classes/Plugins/Export/ExportMediawiki.php:222: $output .= '! style="background:#ffffff" | '
libraries/classes/Plugins/Export/ExportMediawiki.php:301: $output .= '{| class="wikitable sortable" style="text-align:center;"'
libraries/classes/Plugins/Schema/Dia/RelationStatsDia.php:229: <dia:font family="monospace" style="0" name="Courier"/>
libraries/classes/Plugins/Schema/Dia/TableStatsDia.php:175: <dia:font family="monospace" style="0" name="Courier"/>
libraries/classes/Plugins/Schema/Dia/TableStatsDia.php:178: <dia:font family="sans" style="80" name="Helvetica-Bold"/>
libraries/classes/Plugins/Schema/Dia/TableStatsDia.php:181: <dia:font family="sans" style="0" name="Helvetica"/>
libraries/classes/Html/Generator.php:1159: * params (f.e. style="")
libraries/classes/Navigation/NavigationTree.php:1241: $hide = " style='display: none;'";
libraries/classes/Database/Qbe.php:728: . ' style="width: ' . $this->realwidth . '"'
libraries/classes/Database/Qbe.php:762: . ' style="width: ' . $this->realwidth . '"'
libraries/classes/Database/Qbe.php:881: . ' style="width: ' . $this->realwidth . '" size="20">';
libraries/classes/Database/Qbe.php:901: . ' style="width: ' . $this->realwidth . '" size="20">';
libraries/classes/Database/Routines.php:1957: $exportData = '<textarea cols="40" rows="15" style="width: 100%;">'
libraries/classes/Database/Events.php:609: $exportData = '<textarea cols="40" rows="15" style="width: 100%;">'
libraries/classes/Database/Triggers.php:626: $exportData = '<textarea cols="40" rows="15" style="width: 100%;">'
libraries/classes/InsertEdit.php:422: return '<span style="border-bottom: 1px dashed black;" title="'
libraries/classes/InsertEdit.php:1583: return '<span style="color:red">' . __('Error') . '</span><br>' . "\n"
libraries/classes/Util.php:1302: $selected = 'selected="selected" style="font-weight: bold"';
js/vendor/jquery/jquery-ui-timepicker-addon.js:408: html += '<div style="padding-left: 1px"><table class="ui-tpicker-grid-label"><tr>';
js/server/status/monitor.js:1218: ' style="width:' + chartSize.width + 'px; height:' + chartSize.height + 'px;"></div>' +
js/server/status/monitor.js:1259: tooltipHtml += '<br><span style="color:' + seriesColor + '">' +
js/server/status/monitor.js:2123: explain += '<div class="explain-' + i + '"' + (i > 0 ? 'style="display:none;"' : '') + '>';
js/server/status/sorter.js:66: var res = html.innerHTML.match(/<span(\s*style="display:none;"\s*)?\s*class="original">(.*)?<\/span>/);
templates/display/results/table.twig:107: {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Options' %}"
templates/gis_data_editor_form.twig:18: <div id="openlayersmap" style="width: {{width}}px; height: {{height}}px;"{{ srid == 0 ? ' class="hide"' }}></div>
templates/error/report_form.twig:3: <fieldset style="padding-top:0">
templates/export.twig:25: <div class="floatleft" style="margin-left: 50px;">
templates/table/structure/display_structure.twig:345: " style="margin-right: 0;">
templates/table/structure/display_structure.twig:534: {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Partitions' %}"
templates/table/gis_visualization/gis_visualization.twig:4: <div id="gis_div" style="position:relative;">
templates/table/gis_visualization/gis_visualization.twig:45: <div class="pma_quick_warp" style="width: 50px; position: absolute; right: 0; top: 0; cursor: pointer;">
templates/table/gis_visualization/gis_visualization.twig:47: <span class="drop_button" style="padding: 0; border: 0;">
templates/table/gis_visualization/gis_visualization.twig:68: style="width:{{ visualization_settings['width'] }}px;height:{{ visualization_settings['height'] }}px;">
templates/table/index_form.twig:52: {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Advanced options' %}"
templates/table/relation/common_form.twig:104: {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Internal relationships' %}"
templates/table/search/index.twig:99: {{- default_sliders_state == 'closed' ? ' style="display: none; overflow:auto;"' }} class="pma_auto_slider" title="{% trans 'Options' %}"
templates/table/chart/tbl_chart.twig:102: <input style="margin-top:0;" type="text" name="xaxis_label" id="xaxis_label" value="{{ xaxis == -1 ? 'X Values'|trans : keys[xaxis] }}">
templates/table/chart/tbl_chart.twig:148: <div id="resizer" style="width:600px; height:400px;">
templates/table/chart/tbl_chart.twig:149: <div style="position: absolute; right: 10px; top: 10px; cursor: pointer; z-index: 1000;">
templates/database/multi_table_query/form.twig:53: <div id="criteria_div{{ id }}" class="pma_auto_slider" title="{% trans 'criteria' %}" style="display: none; overflow:auto;">
templates/database/designer/database_tables.twig:18: style="position:absolute; left:
templates/database/designer/database_tables.twig:28: style="margin: 0;"
templates/database/designer/database_tables.twig:64: {{- tab_pos[t_n] is defined and tab_pos[t_n]['V'] is empty ? ' style="display: none"' }}>
templates/database/designer/database_tables.twig:90: style="margin: 0;"
templates/database/designer/main.twig:221: <table width="100%" style="padding-left: 3px;"></table>
templates/database/structure/check_all_tables.twig:8: <select name="submit_mult" style="margin: 0 3em 0 3em;">
templates/database/qbe/sort_select_cell.twig:2: <select style="width:{{ real_width }}" name="criteriaSort[{{ column_number }}]" size="1">
templates/database/central_columns/main.twig:148: <table style="display:inline-block;max-width:49%" class="navigation nospacing nopadding">
templates/server/replication/master_replication.twig:19: <div id="replication_slaves_section" style="display: none;">
templates/server/replication/status_table.twig:1:<div id="replication_{{ type }}_section"{{ is_hidden ? ' style="display: none;"' }}>
templates/server/user_groups/user_groups.twig:8: <th style="white-space: nowrap">
templates/server/status/processes/list.twig:12: {%- trans 'Descending' %}" src="themes/dot.gif" style="display: {{ column.sort_order == 'DESC' ? 'none' : 'inline' }}">
templates/server/status/processes/list.twig:14: {%- trans 'Ascending' %}" src="themes/dot.gif" style="display: {{ column.sort_order == 'DESC' ? 'inline' : 'none' }}">
templates/server/privileges/privileges_table.twig:792: <div id="specified_div" style="padding-left:20px;"> Search for
|
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
The following changes are not to be changed
templates/error/generic.twig:8: <style type="text/css">
templates/header.twig:10: <style id="cfs-style">html{display: none;}</style>
templates/header.twig:28: <noscript><style>html{display:block}</style></noscript> |
Inline stying doesn't play well with themes and also forces us to use permisive Content-Security-Policy.
The styling should be moved completely to themes and after this is done the CSP should remove
'unsafe-inline'
for styles.The text was updated successfully, but these errors were encountered: