[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to change attribute to UNSIGNED for am INT VIRTUAL column #13105

Closed
linaspasv opened this issue Mar 19, 2017 · 2 comments
Closed

Unable to change attribute to UNSIGNED for am INT VIRTUAL column #13105

linaspasv opened this issue Mar 19, 2017 · 2 comments
Assignees
@nijel
Labels
Bug A problem or regression with an existing feature
Milestone
4.7.0

Comments

@linaspasv
Copy link

Steps to reproduce

  1. Open table "Structure"
  2. Pick a generated column, and click on "Change"
  3. Try to set an attribute to "UNSIGNED"

Expected behaviour

Should change attribute to "UNSIGNED".

Actual behaviour

Attribute is not being changed.

It seems the UNSIGNED keyword is not being appended after the MEDIUMINT(8) , see the SQL query below:

ALTER TABLE `visas` CHANGE `total_fee` `total_fee` MEDIUMINT(8) AS (embassy_fee + company_fee) VIRTUAL;

Server configuration

Operating system: CentOS 7

Web server: Apache/2.2.15 (CentOS)

Database: 10.1.22-MariaDB

PHP version: 7.1

phpMyAdmin version: 4.8.0-dev

Client configuration

Browser: Chrome

Operating system: Windows 10
@linaspasv linaspasv mentioned this issue Mar 19, 2017
Closed
Achilles-96 added a commit to Achilles-96/phpmyadmin that referenced this issue Mar 19, 2017
@Achilles-96
Fixes adding attribute while updating virtual col phpmyadmin#13105
ed1fc2d 
Signed-off-by: Raghuram Vadapalli<raghuram.vadapalli@research.iiit.ac.in>
@Achilles-96
Copy link
Contributor

Please try this patch.

@linaspasv
Copy link
Author

Hi @Achilles-96 , seems to work for me. Good job!

@nijel nijel self-assigned this Mar 20, 2017
@nijel nijel added the Bug A problem or regression with an existing feature label Mar 20, 2017
@nijel nijel added this to the 4.7.0 milestone Mar 20, 2017
nijel added a commit that referenced this issue Mar 20, 2017
@nijel
Changelog entry for #13105 and #13107
211541f 
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel nijel closed this as completed in c1b9c83 Mar 20, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nijel nijel

Labels
Bug A problem or regression with an existing feature
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
3 participants
@nijel @linaspasv @Achilles-96