[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AJAX error handling #13130

Closed
nijel opened this issue Mar 28, 2017 · 3 comments
Closed

Improve AJAX error handling #13130

nijel opened this issue Mar 28, 2017 · 3 comments
Assignees
@nijel
Labels
Bug A problem or regression with an existing feature
Milestone
4.7.1

Comments

@nijel
Copy link
Contributor
nijel commented Mar 28, 2017

Steps to reproduce

Originally brought by user on twitter who complained about empty error message on network timeout:

c71nwfgxqaesvbg jpg large

See https://twitter.com/the_lux/status/845945943421784064

I've tried to reproduce and the AJAX "Loading" popup seems to be struck even when the network requests immediately fails, what is also not sane behavior. To reproduce

  1. Open phpMyAdmin window.
  2. Stop the web server.
  3. Click on any link.

Expected behaviour

Error message indicating network problems.

Actual behaviour

The "Loading" popup is there forever.

Server configuration

phpMyAdmin version: QA_4_7, master
@nijel nijel added the Bug A problem or regression with an existing feature label Mar 28, 2017
@Fenn-CS
Copy link
Contributor
Fenn-CS commented Mar 28, 2017

Hello @nijel let work through this issue!

@0xTheProDev
Copy link
Contributor

I will be glad to contribute to the issue @nijel

@nijel
Copy link
Contributor Author
nijel commented Mar 30, 2017

Feel free to look at it!

@Fenn-CS Fenn-CS mentioned this issue Apr 2, 2017
Closed
@nijel nijel self-assigned this Apr 5, 2017
@nijel nijel added this to the 4.7.1 milestone Apr 5, 2017
nijel added a commit that referenced this issue Apr 5, 2017
@nijel
Do not try to parse error response
f5655f4 
Issue #13130

Signed-off-by: Michal Čihař <michal@cihar.com>
nijel added a commit that referenced this issue Apr 5, 2017
@nijel
Remove duplicite error handler
a079a55 
There is already ajaxError in js/ajax.js, we can do handling there.

Issue #13130

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel nijel closed this as completed in 799ac0d Apr 5, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nijel nijel

Labels
Bug A problem or regression with an existing feature
Projects
None yet
Milestone
4.7.1
Development

No branches or pull requests
3 participants
@nijel @Fenn-CS @0xTheProDev