[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving move.js of Designer #15345

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Improving move.js of Designer #15345

merged 1 commit into from
Sep 11, 2019

Conversation

Bournvita1998
Copy link
Contributor
@Bournvita1998 Bournvita1998 commented Jun 20, 2019 •
edited
Loading

Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Description

Improved the performance of move.js in the designer section

Fixes #

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@Bournvita1998
Improving move.js of Designer
c245a28 
Signed-off-by: Bournvita1998 <mohit.kuri@research.iiit.ac.in>
williamdes
williamdes requested changes Jun 20, 2019
View reviewed changes
Copy link
Member
@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bournvita1998 please fix the DCO signature :)

@MauricioFauth MauricioFauth changed the base branch from gsoc-db-designer to master July 12, 2019 05:49
devenbansod
devenbansod approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member
@devenbansod devenbansod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamdes williamdes added this to To do in pull-requests Aug 20, 2019
@williamdes williamdes moved this from To do to GSOC in pull-requests Aug 20, 2019
@MauricioFauth MauricioFauth merged commit d3fe6c2 into phpmyadmin:master Sep 11, 2019
pull-requests automation moved this from GSOC to Done Sep 11, 2019
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

@MauricioFauth MauricioFauth self-assigned this Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes requested changes

@MauricioFauth MauricioFauth MauricioFauth approved these changes

@devenbansod devenbansod devenbansod approved these changes

Assignees

@MauricioFauth MauricioFauth

Labels
None yet
Projects
pull-requests
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Bournvita1998 @MauricioFauth @devenbansod @phpmyadmin-bot @williamdes