Modification as mentioned in feature request #1518 #1142
Conversation
Feature request at https://sourceforge.net/p/phpmyadmin/feature-requests/1518/ Signed-off-by: A V Minhaz <minhazav@gmail.com>
Signed-off-by: A V Minhaz <minhazav@gmail.com>
| if($(this).val().length > 0) | ||
| { | ||
| bool = true; | ||
| } |
There was a problem hiding this comment.
Good to see your second commit before some one ask to do those wrappings. Can you modify your if block as well ? See other if blocks in the same file. Use a space before opening curly braces where applicable.
Signed-off-by: A V Minhaz <minhazav@gmail.com>
|
@WhaleWatching , in which case this would trigger confirm dialog against the expected behavior? |
|
Ok, for example |
Signed-off-by: A V Minhaz <minhazav@gmail.com>
|
Oh its my bad.. |
|
This is a new feature so it should go to the master branch. |
|
So I should send a new pull to the master? |
|
Yes, the best is to start a new branch "feature-1518" from master in your repository. In your pull request, target the master branch. |
|
Ok I'll update the code and send a pull to master. |
Feature request at https://sourceforge.net/p/phpmyadmin/feature-requests/1518/
Signed-off-by: A V Minhaz minhazav@gmail.com