-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modification as mentioned in feature request #1518 #1142
Conversation
Feature request at https://sourceforge.net/p/phpmyadmin/feature-requests/1518/ Signed-off-by: A V Minhaz <minhazav@gmail.com>
Signed-off-by: A V Minhaz <minhazav@gmail.com>
if($(this).val().length > 0) | ||
{ | ||
bool = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see your second commit before some one ask to do those wrappings. Can you modify your if block as well ? See other if blocks in the same file. Use a space before opening curly braces where applicable.
Signed-off-by: A V Minhaz <minhazav@gmail.com>
@WhaleWatching , in which case this would trigger confirm dialog against the expected behavior? |
Signed-off-by: A V Minhaz <minhazav@gmail.com>
Oh its my bad.. |
This is a new feature so it should go to the master branch. |
So I should send a new pull to the master? |
Yes, the best is to start a new branch "feature-1518" from master in your repository. In your pull request, target the master branch. |
Ok I'll update the code and send a pull to master. |
Feature request at https://sourceforge.net/p/phpmyadmin/feature-requests/1518/
Signed-off-by: A V Minhaz minhazav@gmail.com