[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Focus back to codemirror editor on selecting column #13126

Closed
wants to merge 1 commit into from
Closed

Fix: Focus back to codemirror editor on selecting column #13126

wants to merge 1 commit into from

Conversation

poush
Copy link
Contributor
@poush poush commented Mar 27, 2017 •
edited
Loading

Fixes #13125

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@poush
Fix: Focus back to codemirror editor on selecting column
262a138 
Signed-off-by: Piyush Agrawal <poush12@gmail.com>
@codecov
Copy link
codecov bot commented Mar 27, 2017 •
edited
Loading

Codecov Report

Merging #13126 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13126   +/-   ##
=======================================
  Coverage   54.36%   54.36%           
=======================================
  Files         465      465           
  Lines       69692    69692           
=======================================
  Hits        37891    37891           
  Misses      31801    31801

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef8dbf...262a138. Read the comment docs.

nijel
nijel suggested changes Mar 28, 2017
View reviewed changes
Copy link
Contributor
@nijel nijel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the fix looks correct for the CodeMirror case, however @OlafvdSpek was not using CodeMirror in the reported issue, can you please fix that as well? It's just the other branches are missing focus call as well.

@nijel nijel self-assigned this Mar 28, 2017
@nijel nijel added this to the 4.7.1 milestone Mar 30, 2017
@nijel
Copy link
Contributor
nijel commented Mar 30, 2017 •
edited
Loading

Landed as f89aafe to QA_4_7, thanks!

@nijel nijel closed this Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijel nijel nijel requested changes

Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

Return focus to textarea after inserting column name
2 participants
@poush @nijel