Fix: PHP Fatal error: Uncaught Error: Call to a member function isAjax() on null #13157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_password.php Signed-off-by: Fenn-CS <fenn25.fn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #13157 +/- ##
==========================================
- Coverage 54.36% 54.36% -0.01%
==========================================
Files 465 465
Lines 69692 69693 +1
==========================================
Hits 37888 37888
- Misses 31804 31805 +1Continue to review full report at Codecov.
|
nijel
reviewed
Apr 7, 2017
user_password.php
Outdated
| @@ -84,6 +84,7 @@ | |||
| */ | |||
| function PMA_getChangePassMessage($change_password_message, $sql_query = '') | |||
| { | |||
| global $response; | |||
There was a problem hiding this comment.
It probably rather should be $response = Response::getInstance();
There was a problem hiding this comment.
@nijel did not want to do that since I found $response = Response::getInstance(); earlier in the file.
https://github.com/phpmyadmin/phpmyadmin/blob/master/user_password.php#L22
But if that's what is better let me do it that way.
Signed-off-by: Fenn-CS <fenn25.fn@gmail.com>
|
Thanks, merged as a661c06 into QA_4_7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to #13154