[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't destroy the session if logins are still present. fixes #12301 #13221

Closed
wants to merge 1 commit into from
Closed

Don't destroy the session if logins are still present. fixes #12301 #13221

wants to merge 1 commit into from

Conversation

WanWizard
Copy link
Contributor

If you are logged-in into multiple database servers, logOut() logs you out of all of them. This fix will prevent that, and will only destroy the session when you log out of the last server.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@WanWizard
Don't destroy the session if logins are still present. fixes phpmyadm…
5fab840 
…in#12301

If you are logged-in into multiple database servers, logOut() logs you out of all of them. This fix will prevent that, and will only destroy the session when you log out of the last server.
@nijel nijel self-assigned this Apr 28, 2017
@nijel nijel added this to the 4.7.1 milestone Apr 28, 2017
nijel added a commit that referenced this pull request Apr 28, 2017
@nijel
Improved handling of logout with disabled LoginCookieDeleteAll
8d6b1dc 
- avoid removing session for cookie auth if LoginCookieDeleteAll is
  disabled
- redirect user to other server rather than to login page
- show message about partial logout
- adjust tests
- this is based on #13221

Fixes #12301

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel
Copy link
Contributor
nijel commented May 4, 2017

Landed as cde775b

@nijel nijel closed this May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WanWizard @nijel @phpmyadmin-bot