[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic search and non-zero-count functionality for callback graph #2434

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Basic search and non-zero-count functionality for callback graph #2434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c82132
initial commit - wip - searchbox
jcuypers Feb 21, 2023
e76b830
Merge branch 'plotly:dev' into dev
jcuypers Feb 21, 2023
2a23bb2
updates on the speedkeys
jcuypers Feb 21, 2023
6805ebe
shortcut keys updates
jcuypers Feb 24, 2023
bf37baf
updated shortkeys
jcuypers Feb 24, 2023
cfa7144
Merge branch 'plotly:dev' into dev
jcuypers Feb 25, 2023
9c286c9
Merge branch 'dev' of https://github.com/jcuypers/dash into dev
jcuypers Feb 25, 2023
6afefd0
callback graph search & non-0 count init. commit
jcuypers Feb 25, 2023
1386b57
change for test 'test_dvui004_width_props'
jcuypers Feb 25, 2023
1ef8f60
added react-hook-mousetrap dependency
jcuypers Feb 25, 2023
12ebaf6
update needed for react-hook-mousetrap
jcuypers Feb 25, 2023
0637f8f
WIP troubleshooting tests window popout
jcuypers Feb 28, 2023
a0b4492
popout window
jcuypers Mar 2, 2023
9b77956
Merge branch 'plotly:dev' into dev
jcuypers Mar 6, 2023
acca08a
wip
jcuypers Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated shortkeys
  • Loading branch information
@jcuypers
jcuypers committed Feb 24, 2023
commit bf37baf4f5ee663bbbb61066f0aeb7a56854e2f3
18 changes: 6 additions & 12 deletions dash/dash-renderer/src/components/error/CallbackGraph/CallbackGraphContainer.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,25 +229,17 @@ function CallbackGraph() {

useMousetrap('0', () => toggle_non_zero());


// need to make this work whenever the input box has focus
useMousetrap('esc', e => {
console.log('Escape')
e.preventDefault();
setSearchBoxActive(false);
});

useMousetrap('s', e => {
//sbi = document.getElementById('searchBoxInput')
console.log('s - search : '+e.target);
if (e.target === document.getElementById('searchBoxInput')) {
console.log('ok this is fine')
} else {
if (e.target !== document.getElementById('searchBoxInput')) {
e.preventDefault();
setSearchBoxActive(!searchBoxActive);
}


});

// Custom hook to make sure cytoscape is loaded.
Expand Down Expand Up @@ -338,7 +330,7 @@ function CallbackGraph() {

useCytoscapeEffect(
cy => {
hideZeroCountNodes(cy, hideZeroOnly)
hideZeroCountNodes(cy, hideZeroOnly);
},
[hideZeroOnly]
);
Expand Down Expand Up @@ -483,11 +475,13 @@ function CallbackGraph() {
</div>
<div className='filter-bar'>
<input

type='checkbox'
id='chkb_non_zero'
checked={hideZeroOnly}
=> {toggle_non_zero(e); e.target.blur()}}
=> {
toggle_non_zero(e);
e.target.blur();
}}
/>
<label for='chkb_non_zero'>Hide zero values</label>
</div>
Expand Down
2 changes: 1 addition & 1 deletion dash/dash-renderer/src/components/error/CallbackGraph/Search/SearchBox.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export function SearchBox(props) {
searchBoxRef.current.value = '';
setSearchTerm('');

props.onSearchBarClicked()
props.onSearchBarClicked();

props.onSelectionChanged(event);
};
Expand Down