[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: postgres 14 (instead of 10) #21721

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

temp: postgres 14 (instead of 10) #21721

wants to merge 1 commit into from

Conversation

janpio
Copy link
Member
@janpio janpio commented Nov 1, 2023

No description provided.

Copy link
Contributor
github-actions bot commented Nov 1, 2023

size-limit report 📦

Path Size
packages/client/runtime/library.d.ts 99.02 KB (0%)
packages/client/runtime/library.js 182.25 KB (0%)
packages/client/runtime/binary.js 600.04 KB (0%)
packages/client/runtime/edge.js 209.7 KB (0%)
packages/cli/build/index.js 5.18 MB (0%)

Copy link
codspeed-hq bot commented Nov 1, 2023

CodSpeed Performance Report

Merging #21721 will degrade performances by 11.98%

Comparing janpio-patch-5 (200386c) with main (ef2a5c6)

Summary

❌ 1 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main janpio-patch-5 Change
getPlatform 8.5 ms 9.7 ms -11.98%

@janpio
Copy link
Member Author
janpio commented Nov 1, 2023

1 surprising snapshot difference:

FAIL src/__tests__/integration/postgresql/introspection.test.ts (8.384 s)
  ● introspection: findUnique where composite PK with foreign key

    expect(received).toMatchSnapshot(hint)

    Snapshot name: `introspection: findUnique where composite PK with foreign key: datamodel 1`

    - Snapshot  - 1
    + Received  + 1

    @@ -18,8 +18,8 @@

      model b {
        id  Int @id @default(autoincrement())
        one Int
        two Int
    -   a   a   @relation(fields: [one, two], references: [one, two], onDelete: NoAction, onUpdate: NoAction, map: "b_one_fkey")
    +   a   a   @relation(fields: [one, two], references: [one, two], onDelete: NoAction, onUpdate: NoAction)
      }
      ↵

      [20](https://github.com/prisma/prisma/actions/runs/6713932243/job/18246392877?pr=21721#step:8:21)1 |       states[scenario.name] = state
      202 |
    > 203 |       expect(introspectionResult.datamodel).toMatchSnapshot(`datamodel`)
          |                                             ^
      204 |       expect(introspectionResult.warnings).toMatchSnapshot(`warnings`)
      205 |
      206 |       await teardownScenario(state)

      at toMatchSnapshot (src/__tests__/__helpers__/integrationTest.ts:203:[45](https://github.com/prisma/prisma/actions/runs/6713932243/job/18246392877?pr=21721#step:8:46))

@CLAassistant
Copy link
CLAassistant commented Jul 8, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants