Minor grammar and typo fixes in web-config docs #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roidelapluie
reviewed
Jul 5, 2021
docs/web-configuration.md
Outdated
| hash. A higher cost will en up slowing down the authentication process. | ||
| Depending on the machine, a cost of 10 will take about ~70ms where a cost of | ||
| hash. A higher cost will end up slowing down the authentication process. | ||
| Depending on the machine, a cost of 10 will take about ~70ms, whereas a cost of | ||
| 18 can take up to a few seconds. That hash will be computed on every |
There was a problem hiding this comment.
Suggested change
| 18 can take up to a few seconds. That hash will be computed on every | |
| 18 can take up to a few seconds. That hash will be computed on the first authenticated HTTP request and then cached. |
There was a problem hiding this comment.
Sure, I just force-pushed with that change.
There was a problem hiding this comment.
I do not see the commit :)
There was a problem hiding this comment.
Problem was between keyboard and chair ;) should be there now!
Signed-off-by: Evan Wies <evan@neomantra.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.