Release 0.6.1 #59
Merged
Release 0.6.1 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually think we should drop VerifyClientCertIfGiven RequireAnyClientCert and RequestClientCert. |
|
Ehhhhhhh we refer to https://golang.org/pkg/crypto/tls/#ClientAuthType for the types so I think we should support all of them. |
|
I guess we could move that documentation into our own repo and eliminate those options |
|
So, should we go ahead with this? We support all of them but users should be aware that only one is secure. |
|
Sure |
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 0.6.1 / 2021-06-30 | |||
|
|
|||
| * [BUGFIX] Allow RequireAnyClientCert as client_auth_type. | |||
There was a problem hiding this comment.
Should we add the PR number?
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu