Add missing sample configuration file #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levi Harrison <git@leviharrison.dev>
|
The link in the docs should be updated to point to https://github.com/prometheus/exporter-toolkit/blob/master/web/web-config.yml. |
Signed-off-by: Levi Harrison <git@leviharrison.dev>
RichiH
approved these changes
Oct 2, 2021
roidelapluie
approved these changes
Oct 2, 2021
|
Thanks! |
|
Err, that's not what I meant. The example config is in the |
|
Whoops... I see that now. This one exercises more of the fields, but we should probably only have one. |
|
Yes, this is definitely a better example, we just need to pick one location. |
|
I prefer |
mrueg
pushed a commit
to mrueg/exporter-toolkit
that referenced
this pull request
Jan 29, 2022
* Added sample configuration file Signed-off-by: Levi Harrison <git@leviharrison.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a link to a non-existent sample configuration file in https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md by adding one. The file is mostly copied from https://github.com/prometheus/prometheus/blob/main/documentation/examples/web-config.yml with the following small changes:
Fixes #65