[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ASFF): create class #4368

Merged
merged 16 commits into from
Jul 4, 2024
Merged

refactor(ASFF): create class #4368

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2b8fc7b
refactor(ASFF): create class
jfagoagas Jul 3, 2024
8e3e2ab
fix: tests
jfagoagas Jul 3, 2024
37b69e6
docs: add docstring to format_compliance
jfagoagas Jul 3, 2024
9510991
fix(asff): if no tags None
jfagoagas Jul 3, 2024
87e0175
fix: do not create json-asff file
jfagoagas Jul 3, 2024
4e86925
fix(security-hub): increment counter
jfagoagas Jul 3, 2024
ae134d7
chore(asff): fix SH tests
pedrooot Jul 4, 2024
8c52547
chore(asff): fix tests for outputs
pedrooot Jul 4, 2024
4d85351
refactor(asff): refactor method filter_security_hub_findings_per_region
pedrooot Jul 4, 2024
952c8bf
refactor(asff): refactor class to retrieve findings per region
pedrooot Jul 4, 2024
35e4866
refactor(asff): pass findings as a dict and fix tests
pedrooot Jul 4, 2024
e5e6d35
refactor(asff): improve docstings
pedrooot Jul 4, 2024
5c11f0a
refactor(asff): refactor class to no pass none
pedrooot Jul 4, 2024
b745181
refactor(asff): fix tests
pedrooot Jul 4, 2024
430f212
Merge branch 'master' of github.com:prowler-cloud/prowler into PRWLR-…
jfagoagas Jul 4, 2024
c7e9264
fix: tests
jfagoagas Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: add docstring to format_compliance
  • Loading branch information
@jfagoagas
jfagoagas committed Jul 3, 2024
commit 37b69e62dcf59d12f6855854bc5725f457044aff
17 changes: 17 additions & 0 deletions prowler/lib/outputs/asff/asff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,23 @@ def format_resource_tags(tags: str) -> dict:

@staticmethod
def format_compliance(compliance: dict) -> tuple[list[dict], list[str]]:
"""
Transforms a dictionary of compliance data into a tuple of associated standards and compliance summaries.

Parameters:
- compliance (dict): A dictionary containing compliance data where keys are standards and values are lists of compliance details.

Returns:
- tuple[list[dict], list[str]]: A tuple containing a list of associated standards (each as a dictionary with 'StandardsId') and a list of compliance summaries.

Notes:
- The method limits the number of associated standards to 20.
- Each compliance summary is a concatenation of the standard key and its associated compliance details.
- If the concatenated summary exceeds 64 characters, it is truncated to 63 characters.

Example:
format_compliance({"standard1": ["detail1", "detail2"], "standard2": ["detail3"]}) -> ([{"StandardsId": "standard1"}, {"StandardsId": "standard2"}], ["standard1 detail1 detail2", "standard2 detail3"])
"""
compliance_summary = []
associated_standards = []
for key, value in compliance.items():
Expand Down
Loading