Update timm to 1.* version and support more encoders #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| in_channels: int = 3, | ||
| depth: int = 5, | ||
| output_stride: int = 32, | ||
| out_indices: Optional[List[int]] = None, |
There was a problem hiding this comment.
Suggested change
| out_indices: Optional[List[int]] = None, | |
| out_indices: Union[str, List[int]] = "first", |
Comment on lines
+56
to
+57
| if "encoder_indices" in kwargs and kwargs["encoder_indices"] is None: | ||
| kwargs["encoder_indices"] = "first" |
There was a problem hiding this comment.
Suggested change
| if "encoder_indices" in kwargs and kwargs["encoder_indices"] is None: | |
| kwargs["encoder_indices"] = "first" | |
| if "out_indices" in kwargs and kwargs["out_indices"] is None: | |
| kwargs["out_indices"] = "first" |
While it's called encoder_indices in the function select_feature_indices, in TimmUniversalEncoder it is still called out_indices
Comment on lines
+69
to
+73
| encoder_indices = kwargs.pop("encoder_indices", None) | ||
| if encoder_indices is not None: | ||
| logger.warning( | ||
| "Argument `encoder_indices` is supported only for `tu-` encoders (Timm) and will be ignored." | ||
| ) |
There was a problem hiding this comment.
Suggested change
| encoder_indices = kwargs.pop("encoder_indices", None) | |
| if encoder_indices is not None: | |
| logger.warning( | |
| "Argument `encoder_indices` is supported only for `tu-` encoders (Timm) and will be ignored." | |
| ) | |
| out_indices = kwargs.pop("encoder_indices", None) | |
| if out_indices is not None: | |
| logger.warning( | |
| "Argument `out_indices ` is supported only for `tu-` encoders (Timm) and will be ignored." | |
| ) |
|
Hi @wouterzwerink thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make most of the models from timm compatible with decoders (including transformers and convnext models)