[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(sql): more efficient pattern lookup for short ASCII patterns #4706

Merged
merged 6 commits into from
Jul 11, 2024
Merged

perf(sql): more efficient pattern lookup for short ASCII patterns #4706

merged 6 commits into from
Jul 11, 2024

Conversation

puzpuzpuz
Copy link
Contributor

Found a way to simplify ConstContainsSwarVarcharFunction's SWAR loop while looking at Rosti.

-- master: 1s
-- patch:  866ms
SELECT COUNT(*) FROM hits WHERE URL LIKE '%google%';

@puzpuzpuz puzpuzpuz added SQL Issues or changes relating to SQL execution Performance Performance improvements labels Jun 23, 2024
@puzpuzpuz puzpuzpuz self-assigned this Jun 23, 2024
@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz_slightly_faster_ascii_like branch from dc00b01 to 734ac7d Compare June 23, 2024 12:22
mtopolnik
mtopolnik previously approved these changes Jul 10, 2024
View reviewed changes
@puzpuzpuz
Copy link
Contributor Author

@mtopolnik thanks for the review!

@puzpuzpuz
Copy link
Contributor Author
puzpuzpuz commented Jul 10, 2024 •
edited
Loading

@mtopolnik could you reapprove? I had to remove anchor from the URL in the javadoc since it looks broken and javadoc report dislikes that. See 4b89774

@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz_slightly_faster_ascii_like branch from 679531a to 4b89774 Compare July 10, 2024 11:24
@ideoma
Copy link
Collaborator
ideoma commented Jul 11, 2024

[PR Coverage check]

😍 pass : 9 / 9 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/std/SwarUtils.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/regex/AbstractLikeVarcharFunctionFactory.java 8 8 100.00%

@bluestreak01 bluestreak01 merged commit 20ad756 into master Jul 11, 2024
28 checks passed
@bluestreak01 bluestreak01 deleted the puzpuzpuz_slightly_faster_ascii_like branch July 11, 2024 12:08
ideoma pushed a commit that referenced this pull request Jul 12, 2024
@puzpuzpuz @ideoma
perf(sql): more efficient pattern lookup for short ASCII patterns (#4706
dac85d7 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtopolnik mtopolnik mtopolnik approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
Performance Performance improvements SQL Issues or changes relating to SQL execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@puzpuzpuz @ideoma @mtopolnik @bluestreak01