fix(core): 💥 breaking change - enforce fail-fast on NFS #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFS is known to cause issues. It is better to fail at startup rather than pretending everything is fine, only to inevitably encounter problems later. Although NFS has never been supported, this is the first time we are enforcing this, which could be a breaking change for some users. When NFS is detected QuestDB startup fails with this error: ``` Error: Unsupported Filesystem Detected. QuestDB cannot start because the '/tmp/dbroot-fixes' is located on an NFS filesystem, which is not supported. Please relocate your 'db root' to a supported filesystem to continue. For a list of supported filesystems and further guidance, please visit: https://questdb.io/docs/deployment/capacity-planning/#supported-filesystems [path=/tmp/dbroot-fixes/db, kind=db, fs=NFS] ``` We don't enforce this for `sql copy input` where it's OK. (but it's still enforced for the SQL COPY working dir)
ideoma
reviewed
Jul 3, 2024
bluestreak01
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFS is known to cause issues. It is better to fail at startup rather than pretending everything is fine, only to inevitably encounter problems later. Although NFS has never been supported, this is the first time we are enforcing this, which could be a breaking change for some users.
When NFS is detected QuestDB startup fails with this error:
We don't enforce this for
sql copy inputwhere it's OK. (but it's still enforced for the SQL COPY working dir)