Fix indexed-only behavior for proxy shard #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xy shard decide where to search better
|
@generall thanks for reviving this discussion. |
timvisee
approved these changes
Apr 10, 2024
|
Indeed, moving it to the level of index would be a better option. Also resolves the bug with sparse vectors we had. WDYT about the current version @keremnc ? |
|
Thanks @generall, this looks good to me |
timvisee
approved these changes
Apr 11, 2024
timvisee
pushed a commit
that referenced
this pull request
Apr 22, 2024
* move check for unindexed segment size inside the segment to allow proxy shard decide where to search better * fmt * move indexed_only check inside the plain index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to rethink a suggestion proposed in #3186
Instead of introducing a new parameter, we simply fix the problem of excluding proxy shard with too many changes from the search by allowing each individual raw segment to decide if it can do search or not.
P.S.
There is a follow-up PR with post-refactoring of simple
searchmethod.