[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jci Hitachi Dehumidifier Light Integration #70

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

amigcamel
Copy link
Contributor
  • Added support for controlling Jci Hitachi dehumidifier panel LED brightness within Home Assistant.
  • Created a new 'light' platform to handle brightness control for dehumidifier LEDs.
  • Updated README to reflect the addition of 'Display brightness' feature.
  • Modified 'init.py' to include 'light' in the list of supported platforms for the integration.

Just so you know, there was a request of this (#60 機體顯示亮度支援) a couple of months ago,
and it's implemented in this PR.

- Added support for controlling Jci Hitachi dehumidifier panel LED brightness within Home Assistant.
- Created a new 'light' platform to handle brightness control for dehumidifier LEDs.
- Updated README to reflect the addition of 'Display brightness' feature.
- Modified '__init__.py' to include 'light' in the list of supported platforms for the integration.
Copy link
Owner
@qqaatw qqaatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution.

I can't test this myself, so please be sure the added functionality works in your local env. If someone reports that this doesn't work, the PR may get reverted.

custom_components/jcihitachi_tw/light.py Outdated Show resolved Hide resolved
custom_components/jcihitachi_tw/light.py Outdated Show resolved Hide resolved
@amigcamel
Copy link
Contributor Author

Thanks a lot for your contribution.

I can't test this myself, so please be sure the added functionality works in your local env. If someone reports that this doesn't work, the PR may get reverted.

Sure thing.
Here's a clip I recorded for the panel LED integration, please have a look when you're available, TIA.
https://github.com/qqaatw/JciHitachiHA/assets/7016634/7c53f9b3-b170-4ba5-b201-f5e603e66983

@qqaatw qqaatw merged commit 47ccbd0 into qqaatw:master Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants