[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-thread-safe operation #77

Merged
merged 2 commits into from
May 7, 2024

Conversation

cloudrainstar
Copy link
Contributor

I followed the fix mentioned here: home-assistant/core#115235 (comment) and adapted it here, and it looks like it should fix #76.

Copy link
Owner
@qqaatw qqaatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this locally with Home Assistant core 2024.5 onward?

custom_components/jcihitachi_tw/__init__.py Outdated Show resolved Hide resolved
@cloudrainstar
Copy link
Contributor Author
cloudrainstar commented May 7, 2024

Have you tested this locally with Home Assistant core 2024.5 onward?

Yes, I updated my HA Core to 2024.5.2 yesterday and ran into this issue, so I found other custom components had the same issue and found that their fix solves the issue here. I've been running my HA instance on this code change locally since yesterday.

Copy link
Owner
@qqaatw qqaatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@qqaatw qqaatw merged commit f1254f7 into qqaatw:master May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems after upadting to HA Core 2024.5.0 , call service on Hitachi Climate Entity will bring up error message
2 participants