web: preferentially use node 16 to compile #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrelb
approved these changes
Oct 26, 2021
|
Does this take care of #2724 as well? |
Herschel
approved these changes
Oct 26, 2021
|
I expect #2724 was fixed when archiverjs/node-archiver#491 was fixed, which was probably version 5.3.0 (though the issue is several dependencies deep). Looks like we've hit the same problem with "Required" builds as before: can "Test Node.js 12 / Rust stable / ubuntu-latest" and "Test Node.js 12 / Rust stable / windows-latest" be made non-required (and after this possibly the same builds but with 16 be made required) |
|
Yep, I'll force merge this PR, and the new build steps will appear in the repo settings, at which point I can switch the new ones to required. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node has released 16 as the latest LTS version, leaving 14 as the maintenance version. Preferentially use node 16 to compile.
In theory, it should be more performant. In practice, I can't really see a difference.
Nonetheless, it's worth doing, and I expect our dependent libraries to stop supporting node 12 as time goes by.