Update sys-info to v0.9 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing in the gcc windows build |
|
Omg, is this serious? 🤦
@rbtcollins Is it okay if I'll try to upgrade the version of mingw used for the CI to at least 6.3.0? |
|
Go for it
…On Tue, 8 Jun 2021, 22:48 Alexander Ovchinnikov, ***@***.***> wrote:
Omg, is this serious? 🤦
warning: c/windows.c: In function 'get_cpu_speed':
warning: c/windows.c:71:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
warning: for (unsigned int i = 0; i < num; i++) {
warning: ^
warning: c/windows.c:71:2: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
@rbtcollins <https://github.com/rbtcollins> Is it okay if I'll try to
upgrade the version of mingw used for the CI to at least 6.3.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADZ7XWDMCWYTWGS7QEF3ELTRZ62DANCNFSM45BCHNFA>
.
|
|
@rbtcollins Done! Seems to run on my fork. I've used the same mingw packages as rustup. |
kinnison
requested changes
Jun 13, 2021
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
|
Oh, sorry, I didn't realize there was a template 😬 Thanks for fixing this up! |
kinnison
approved these changes
Jun 13, 2021
|
@Alovchin91 Yeah this is borrowed from Rustup's CI, each file does have a comment like: at the top, but that's easy to miss :/ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates sys-info dependency to v0.9 which improves Windows support to be arch-independent and enables building rustup for Windows on ARM64: rust-lang/rustup#2612
This is a re-post of this PR: #14
Should also help with #15