[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 馃悶 skip broken docutils package, revert numpy version lock #1317

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

onuralpszr
Copy link
Collaborator
@onuralpszr onuralpszr commented Jun 28, 2024

Description

Poetry installation shows that docutils broken because sdist for 0.21 release is versioned "0.21.post1" but the directory inside it is "0.21". Therefore, it is not installable via poetry and cause issues

Secondly, I removed numpy version lock since opencv fix via

Therefore let's merge this PR, I also tested via tox and manually created venvs before sent

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@onuralpszr onuralpszr added the bug Something isn't working label Jun 28, 2024
@onuralpszr onuralpszr requested a review from LinasKo June 28, 2024 19:10
@onuralpszr onuralpszr self-assigned this Jun 28, 2024
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@LinasKo
Copy link
Collaborator
LinasKo commented Jul 1, 2024

Tested it, built the docs, installed python-opencv explicitly - the numpy no longer causes issues.

I've seen the docutils issue before and failed to find a solution. Thanks a lot for tracking it down!

@LinasKo LinasKo merged commit 8d26a92 into develop Jul 1, 2024
9 checks passed
@LinasKo LinasKo deleted the fix/poetry/dep branch July 1, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants