-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slicer for small object detection #282
Conversation
Hi @hardikdava 👋🏻 Is it ready for review? |
@SkalskiP Yeah, it is ready for review. |
@hardikdava I tried to run Notebook but it crashed. Is it up to date? |
@SkalskiP Ohh, it is an issue of image downloading. |
@SkalskiP Can you manually upload this image for testing? It should work. I just tested it. |
raw URL good for wget : https://raw.githubusercontent.com/spmallick/learnopencv/master/Exploring-Slicing-Aided-Hyper-Inference/test_images/bird.jpg Tip info : https://stackoverflow.com/questions/4604663/download-single-files-from-github/4605068#4605068 !wget 'https://raw.githubusercontent.com/spmallick/learnopencv/master/Exploring-Slicing-Aided-Hyper-Inference/test_images/bird.jpg'
from IPython.display import Image, display
display(Image('/content/bird.jpg')) |
@SkalskiP It is updated now!, it is working. Thanks @onuralpszr |
You're welcome :) I am glad to help |
Hi @hardikdava 👋🏻 I'd add some unit tests to this PR. I can do that if ou don't have time. |
Hi @hardikdava 👋🏻 I will work on a few unit tests before merging. |
@SkalskiP Thanks for covering some tasks for me. |
@hardikdava can I only ask one question? Why is |
@SkalskiP yeah, we can do it with just |
I'll try to do some minor changes when I'll be working on tests. |
@hardikdava slicer looks fantastic! Screen.Recording.2023-08-29.at.18.17.27.mov |
Looks really Amazing :) |
Description
This PR is implementation of #250
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Google colab link: https://colab.research.google.com/drive/1RNvsVWpkklUMZy5cjRs9y5yzBSHU9KRi?usp=sharing
Docs
docs/supervision/detection/tools/slicer.md