[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed empty detections for deepsparse #348

Merged
merged 2 commits into from
Sep 2, 2023
Merged

fixed empty detections for deepsparse #348

merged 2 commits into from
Sep 2, 2023

Conversation

hardikdava
Copy link
Collaborator
@hardikdava hardikdava commented Sep 2, 2023

Description

This PR is for #347 . The main reason was that it was not able to handle empty detections. Also documentation is fixed now.

Colab link: https://colab.research.google.com/drive/17AROUpY_vHKXW0RG2_4VzXiDqPps09TI?usp=sharing

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@hardikdava hardikdava self-assigned this Sep 2, 2023
@hardikdava
Copy link
Collaborator Author

@onuralpszr can you review it and then please merge it.

Copy link
Collaborator
@onuralpszr onuralpszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM works merging in

@onuralpszr onuralpszr merged commit 78411b1 into develop Sep 2, 2023
5 checks passed
@SkalskiP
Copy link
Collaborator
SkalskiP commented Sep 5, 2023

Thanks @hardikdava and @onuralpszr 🙏🏻

hi-sushanta pushed a commit to hi-sushanta/supervision that referenced this pull request Sep 25, 2023
* fixed empty detections for deepsparse
* fix(pre_commit): 🎨 auto format pre-commit hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@SkalskiP SkalskiP deleted the fix/deepsparse branch January 2, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants