[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervision demo notebook fix and yolo-nas fix #416

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

onuralpszr
Copy link
Collaborator
@onuralpszr onuralpszr commented Oct 5, 2023

Description

Supervision demo update for supervision 0.15.0 and other fixes such as yolo-nas

Fix: #415

List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@onuralpszr onuralpszr added the bug Something isn't working label Oct 5, 2023
@onuralpszr onuralpszr self-assigned this Oct 5, 2023
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@onuralpszr onuralpszr force-pushed the notebook-fixes branch 3 times, most recently from a6b2792 to 4aa996d Compare October 5, 2023 12:34
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@SkalskiP
Copy link
Collaborator
SkalskiP commented Oct 5, 2023

Interesting... YOLO-NAS changed API?

@SkalskiP SkalskiP merged commit 77c126e into develop Oct 5, 2023
6 checks passed
@onuralpszr
Copy link
Collaborator Author
onuralpszr commented Oct 5, 2023

Interesting... YOLO-NAS changed API?

Broken part fixed So we may need to make 0.15.1 release for fix it.

@SkalskiP
Copy link
Collaborator
SkalskiP commented Oct 5, 2023

@onuralpszr
Copy link
Collaborator Author

@onuralpszr we will need to make the exact change here: https://supervision.roboflow.com/detection/core/#supervision.detection.core.Detections.from_yolo_nas ?

No we don't need to, I only fix "if" check because, code was failing so I fixed it. yolo-nas API still same we don't need to update docs it just I miss add "prediction" I notice while I was testing notebook, it was a overlook, sorry about that.

@onuralpszr onuralpszr added the hacktoberfest-accepted Contribute to the notion of open-source this October! label Oct 5, 2023
@SkalskiP SkalskiP deleted the notebook-fixes branch January 2, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Contribute to the notion of open-source this October!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sv.MaskAnnotator not working
2 participants