Added box mask annotators #422

hardikdava · 2023-10-05T15:59:31Z

Description

This PR is related to #421

List any dependencies that are required for this change.

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

from ultralytics import YOLO
import cv2
import supervision as sv


image = cv2.imread("bus.jpg")

model = YOLO("yolov8n.pt")

detections = sv.Detections.from_ultralytics(model.predict(image, imgsz=416)[0])

box_mask_annotator = sv.BoxMaskAnnotator()
image = box_mask_annotator.annotate(image, detections)


cv2.imshow("Result", image)
cv2.waitKey(0)

Docs

Docs updated? What were the changes:

hardikdava · 2023-10-05T16:01:28Z

@SkalskiP The document needs to be updated. Can you handle that?

hardikdava · 2023-10-06T17:40:25Z

@onuralpszr Can you review this?

SkalskiP · 2023-10-06T18:25:29Z

Hi, @hardikdava 👋🏻! I'll take a look now.

onuralpszr · 2023-10-06T18:27:22Z

supervision/annotators/core.py

+                color=color.as_bgr(),
+                thickness=-1,
+            )
+        scene = cv2.addWeighted(


@hardikdava we merge "faster" mask PR so we should replace that cv2.addWeighted this that code so it can be faster as well for start

PR link : #426

Could that be relevant in the context of this PR as well #426 ?

@SkalskiP yes

SkalskiP · 2023-10-06T18:27:32Z

btw, @hardikdava you know that you can create branches directly in supervision? You don't need to do it in your fork.

SkalskiP · 2023-10-06T18:43:09Z

Example result:

SkalskiP · 2023-10-06T18:56:42Z

@onuralpszr and @hardikdava I updated the docs and tested them. It works. Should we merge it and go back if people complain about performance in the future?

onuralpszr · 2023-10-06T19:08:40Z

@onuralpszr and @hardikdava I updated the docs and tested them. It works. Should we merge it and go back if people complain about performance in the future?

Okay merge it. I also have different approach for performance I was thinking and we can always improve more too.

Added box mask annotators

ef43640

hardikdava marked this pull request as ready for review October 5, 2023 16:00

hardikdava requested a review from SkalskiP October 5, 2023 16:00

hardikdava requested a review from onuralpszr October 6, 2023 17:40

onuralpszr reviewed Oct 6, 2023

View reviewed changes

SkalskiP linked an issue Oct 6, 2023 that may be closed by this pull request

Create sv.BoxMaskAnnotator #421

Closed

SkalskiP assigned hardikdava Oct 6, 2023

SkalskiP added enhancement New feature or request api:annotator Annotators hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti labels Oct 6, 2023

SkalskiP and others added 4 commits October 6, 2023 20:51

Update annotators in docs and code

e7c242b

fix(pre_commit): 🎨 auto format pre-commit hooks

cc93bba

Improve the documentation for annotators class

bed28e3

fix(pre_commit): 🎨 auto format pre-commit hooks

669c065

onuralpszr added the hacktoberfest-accepted Contribute to the notion of open-source this October! label Oct 6, 2023

onuralpszr approved these changes Oct 6, 2023

View reviewed changes

SkalskiP merged commit d30d807 into roboflow:develop Oct 6, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added box mask annotators #422

Added box mask annotators #422

Added box mask annotators #422

Added box mask annotators #422

Conversation

Description

Type of change

How has this change been tested, please provide a testcase or example of how you tested the change?

Docs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment