feat(assets): ✨ assets and assets downloader add-on for supervision[assets] #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bac3f7
to
b2514a1
Compare
…ssets] Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
b2514a1
to
2ab5941
Compare
Renamed enum and variables to improve clarity for VideoAssets in asset_list.py. For instance, MILK_1 is updated to MILK_BOTTLED_PLANT and PEOPLE_WALKING_BW to PEOPLE_WALKING. Also, the VIDEO_ASSETS dictionary type hint updated to Dict. Additionally, a new method 'list' added to class VideoAssets that returns a list of all enum values.
|
@SkalskiP should we add your classic pictures too ? |
|
Hi @onuralpszr 👋🏻! Let's try to merge this first. I'm facing a few issues that I'm trying to solve. |
issue on this PR ? |
…e' leading to missed video asset downloads. The reference has been corrected to use 'filename' for proper checking and downloading.
Updated 'asset_name' to 'filename' in downloader.py. The downloader was using the incorrect variable 'asset_name', causing failed video asset downloads. Correcting to 'filename' allows for accurate md5 check and download."
Updated the reference for the md5 hash in downloader.py.
The code for the downloader function in the supervision/assets/downloader.py file has been refactored and optimized. Package imports were cleaned up to remove unnecessary functions and the "path_exists" and "os_remove" functions were replaced with their pathlib equivalents to improve consistency.
The file asset_list.py has been renamed to list.py for better readability and simplicity. In the VideoAssets enumeration, additional information has been included. This includes specific details for each member of the enum, notably the filename of the related video and its URL.
The 'Response' imported module from 'requests' in downloader.py is not needed.
Updated the docstring comment's format inside the VideoAssets enum in supervision/assets/list.py. The update aligns with PEP 8 E501 error code that requires line too long (>80 characters).
Updated the docstring comment's format inside the VideoAssets enum in supervision/assets/list.py. The update aligns with PEP 8 E501 error code that requires line too long (>80 characters). Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
9e449b3
to
b6001e3
Compare
# Conflicts: # supervision/assets/list.py
Expanded the documentation to include instructions on how to install and use the Supervision assets utility. Instructions include steps for performing the installation using pip, allowing users to easily download video files for their demos.
Updated the docstring comment's format inside the VideoAssets enum in supervision/assets/list.py. The update aligns with PEP 8 E501 error code that requires line too long (>80 characters). Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
e9866c2
to
28fb656
Compare
SkalskiP
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce download assets for testing detections/segmentations
Install Method
"pip install supervision[assets]" as a optional install. This will install requests and tqdm but supervision can be used without install it. No effects to rest of the supervision.
List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Docs