[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sv.dot marker annotator #396 #492

Merged

Conversation

PankajKrana
Copy link
Contributor

Description

This change addresses issue #396.

List any dependencies that are required for this change.

Type of change

This feature implements the sv.DotMarkerAnnotator in the Supervision library. The DotMarkerAnnotator is designed to mark objects related to sv.Detections with dots. It allows the user to choose a color palette and a color mapping strategy, including options such as index, class, or track. The position of the dot in relation to the box can also be controlled using sv.Position.

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

YOUR_ANSWER

Any specific deployment considerations

if any changes need suggest me

@CLAassistant
Copy link
CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap.

@SkalskiP
Copy link
Collaborator

Hi, @PankajKrana 👋🏻 could you accept the CLA agreement?

@SkalskiP SkalskiP self-requested a review October 18, 2023 14:57
@SkalskiP SkalskiP added enhancement New feature or request api:annotator Annotators hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti labels Oct 18, 2023
@SkalskiP SkalskiP linked an issue Oct 18, 2023 that may be closed by this pull request
SkalskiP and others added 2 commits October 18, 2023 18:09
The DotMarkerAnnotator class has been refactored and named DotAnnotator for simplicity. It's now part of the core annotators to conform with the project structure. The color lookup on the DotAnnotator now uses the 'color_lookup' parameter, allowing for more flexibility and customization in the colors used for the annotations. All the changes aim to standardize the way different annotators are organized and make color customization easier.
@SkalskiP
Copy link
Collaborator

Hi, @PankajKrana 👋🏻! Thanks a lot for your contribution 🙏🏻 Merging!

@SkalskiP SkalskiP merged commit 6815814 into roboflow:develop Oct 18, 2023
5 checks passed
@PankajKrana PankajKrana deleted the Create_sv.DotMarkerAnnotator_#396 branch January 21, 2024 13:24
@PankajKrana PankajKrana restored the Create_sv.DotMarkerAnnotator_#396 branch January 21, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:annotator Annotators enhancement New feature or request hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti
Projects
Status: Current Release: Done
Development

Successfully merging this pull request may close these issues.

Create sv.DotMarkerAnnotator
3 participants