feat(color.py): ✨ add color constants/properties #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the WHITE, BLACK, RED, GREEN, and BLUE color constants to the Color class in color.py. These constants represent the corresponding colors in the RGB color space. Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
fa7db99
to
bb4d741
Compare
SkalskiP
requested changes
Jan 18, 2024
Deprecated the `white`, `black`, `red`, `green`, and `blue` methods in the `Color` class. Users should now use the `WHITE`, `BLACK`, `RED`, `GREEN`, and `BLUE` properties instead. This change improves the API and makes it more consistent. Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
|
@SkalskiP changes are done. |
SkalskiP
approved these changes
Jan 19, 2024
|
Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the WHITE, BLACK, RED, GREEN, and BLUE color constants to the Color class in color.py. These constants represent the corresponding colors in the RGB color space. (Fix: #753)
List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.