LineZoneAnnotator make display of int/out values optional #802
Conversation
|
|
|
Hi @Kadermiyanyedi 👋🏻! The logic looks good. I like that you decided to extract the drawing of the text using a separate method. Could we go a step further? We already have |
…_count method and add center method to vector
|
Awesome job @Kadermiyanyedi! 🔥 I left a few more comments, but we are close. I think we should be done after this. |
|
@SkalskiP @onuralpszr I resolved all comments, can you review again please :) |
|
@Kadermiyanyedi, could you make your Google Colab public? The code looks good I just want to confirm everything works :) |
I updated Colab link, now you can access it :) |
|
Tests are passed that looks good. |
|
Collab also works perfectly fine on my end. |
|
Awesome! @Kadermiyanyedi, thanks a lot for your help! 🙏🏻 We are merging! Are you on LinkedIn? |
|
@onuralpszr Thank you, you've been very helpful in assigning the relevant task and aiding my understanding of the project @SkalskiP Thank you very much for taking the time to provide feedback and review. Your comments are highly valuable |
|
My pleasure! |
Description
LineZoneAnnotator has two new boolean parameters, display_in_count and display_out_count, to the functions display_in_count and display_on_count. When set to True, these parameters display the input/output values. (Fix: #792)
To optimize performance and avoid unnecessary mathematical calculations when the values are not displayed, I encapsulated these calculations within a separate function.
For testing purposes, please refer to the provided Colab link.
Type of change
Changes Made:
Added two boolean parameters, display_in_count and display_out_count, to display_in_count and display_on_count functions.
Implemented conditional logic to display input/output values based on the boolean parameters.
Moved unnecessary mathematical calculations to a separate function to optimize performance.
Example Output: Google Drive Link
Please review thank you :)