-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New function [JSONSink] - Allowing to serialise Detections to a JSON file #819
New function [JSONSink] - Allowing to serialise Detections to a JSON file #819
Conversation
Hi @AdonaiVera 👋🏻 ! I see you submitted both I recommend working first together on one of them ( |
c762c6d
to
a8e11ae
Compare
Hi @SkalskiP Please let me know your thoughts on the changes and if you have any further suggestions 🥷 |
3efe0d0
to
7cca51f
Compare
7cca51f
to
d949631
Compare
@AdonaiVera thank you for your contributions, I see that changes based on CSVSink so it is fine. I merging in. I trimmed couple of commits that so make it cleaner. |
Hi @onuralpszr, amazing thank you mi amigo ! 💪 |
Description
This PR introduces the
JSONSink
class to address structured logging of object detection data into JSON format, as requested in issue #748. The class supports logging of bounding boxes, class IDs, confidence scores, and frame numbers, enhancing post-processing data analysis and interpretability.The PR includes:
JSONSink
class implementation.JSONSink
with a video processing pipeline.Note: The
JSONSink
class was placed directly in the utils folder in the file.py file due to its capability to handle various types of file operations integral to the project's core functionality. Open to suggestions if there's a more appropriate location within the project structure.Type of Change
JSONSink
class for structured logging of detection data.Testing
The
JSONSink
class was validated through a series of unit tests, covering:A demo script demonstrates the class's usage within a video processing workflow, annotating video frames and logging detections to a JSON file. Demo Here
Documentation Updates
JSONSink
class documentation within the module, detailing its purpose, usage, and example usage.JSONSink
class.