[go: nahoru, domu]

Skip to content

Commit

Permalink
Fix 404s to Tapbox sources (flutter#1747)
Browse files Browse the repository at this point in the history
* Fix 404s to Tapbox sources

The GitHub raw content links don't exist. The code only exists as embedded snippets in the page, not in the src/_includes/code directory. So, just drop the invalid links.

Closes flutter#1713

* Upgrade pubspec package versions
  • Loading branch information
chalin committed Nov 16, 2018
1 parent a96de8d commit 10baf17
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
2 changes: 1 addition & 1 deletion pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ packages:
name: linkcheck
url: "https://pub.dartlang.org"
source: hosted
version: "2.0.4"
version: "2.0.5"
logging:
dependency: transitive
description:
Expand Down
16 changes: 2 additions & 14 deletions src/docs/development/ui/interactive/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,15 +393,14 @@ automatically scrolls when its content exceeds the render box. Most
developers using ListView don't want to manage ListView's
scrolling behavior, so ListView itself manages its scroll offset.

The _TapboxAState class:
The `_TapboxAState` class:

* Manages state for TapboxA.
* Manages state for `TapboxA`.
* Defines the `_active` boolean which determines the box's current color.
* Defines the `_handleTap()` function, which updates `_active` when the box is
tapped and calls the `setState()` function to update the UI.
* Implements all interactive behavior for the widget.

<!-- code/layout/lakes-interactive/main.dart -->
<!-- skip -->
{% prettify dart %}
// TapboxA manages its own state.
Expand Down Expand Up @@ -464,9 +463,6 @@ class MyApp extends StatelessWidget {
}
{% endprettify %}

**Dart code:**
[`lib/main.dart`](https://raw.githubusercontent.com/flutter/website/master/src/_includes/code/layout/tapbox-a/main.dart)

<hr>

<a name="parent-managed"></a>
Expand Down Expand Up @@ -495,7 +491,6 @@ The TapboxB class:
* Extends StatelessWidget because all state is handled by its parent.
* When a tap is detected, it notifies the parent.

<!-- code/layout/tapbox-b/main.dart -->
<!-- skip -->
{% prettify dart %}
// ParentWidget manages the state for TapboxB.
Expand Down Expand Up @@ -561,9 +556,6 @@ class TapboxB extends StatelessWidget {
}
{% endprettify %}

**Dart code:**
[`lib/main.dart`](https://raw.githubusercontent.com/flutter/website/master/src/_includes/code/layout/tapbox-b/main.dart)

<aside class="alert alert-success" markdown="1">
<i class="fa fa-lightbulb-o"> </i> **Tip:**
When creating API, consider using the `@required` annotation for
Expand Down Expand Up @@ -614,7 +606,6 @@ The _TapboxCState object:
[widget](https://docs.flutter.io/flutter/widgets/State/widget.html)
property.

<!-- code/layout/tapbox-c/main.dart -->
<!-- skip -->
{% prettify dart %}
//---------------------------- ParentWidget ----------------------------
Expand Down Expand Up @@ -719,9 +710,6 @@ it doesn't make much sense. The developer cares whether the box is active.
The developer probably doesn't care how the highlighting is managed,
and prefers that the tap box handles those details.

**Dart code:**
[`lib/main.dart`](https://raw.githubusercontent.com/flutter/website/master/src/_includes/code/layout/tapbox-c/main.dart)

<hr>

<a name="other-interactive-widgets"></a>
Expand Down

0 comments on commit 10baf17

Please sign in to comment.