[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error trapping to flatfile_read() #61

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

btupper
Copy link
Contributor
@btupper btupper commented Apr 17, 2024

This PR provides a small effort at error trapping to resolve this issue. I'm not schooled in biology/genetics so I am unsure of the downstream consequences, but I can attest that it resolves the block encountered without the fix.

@joelnitta
Copy link
Contributor

Thanks! It looks like this is a fix for when the accession is too long (such as a full genome). I have additional change to make to your PR. Can you add me as a collaborator to your fork so I can add it?

@joelnitta joelnitta merged commit c67eefe into ropensci:main Apr 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants