This repository has been archived by the owner on Feb 4, 2023. It is now read-only.
Move Column logic from Twig to PHP #861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, options should not be generated manually from twig. You only did it for columns options but I think this should be done for everything. (wip so I guess this is planned?) I think:
|
BC break: ColumnInterface has been changed
|
I've changed the method name and removed Since |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Twig is used to render the options. I think Twig shouldn't be used like this: this is where PHP should be used instead. Related to #819. This is just a 'proof of concept', so please share your thoughts about this.
Not the most important or this idea, but the HTML will look better too:
